673199 - Gecko Alert "java.net.MalformedURLException: Protocol not found:" after getting an update notification that a build is available

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Mozilla/5.0 (Android; Linux armv71; rv8.0a1) Gecko/20110718 Firefox/8.0a1 Fennec/8.0a1
Device: Thunderbolt
OS: Android 2.2

1. download the 7/18/2011 build of fennec
2. go to about:fennec
3. setup logcat for device
4. select the button for checking for an update
5. check logcat

Expected: no Gecko Alert
Actual:

07-21 12:04:17.690: INFO/GeckoAppJava(3724): GeckoAppShell.showAlertNotification
07-21 12:04:17.690: INFO/GeckoAppJava(3724): - image = ''
07-21 12:04:17.690: INFO/GeckoAppJava(3724): - title = 'Nightly 8.0a1 available'
07-21 12:04:17.690: INFO/GeckoAppJava(3724): - text = 'Download & Install…'
07-21 12:04:17.690: INFO/GeckoAppJava(3724): - cookie = ''
07-21 12:04:17.690: INFO/GeckoAppJava(3724): - name = 'update-app'
07-21 12:04:17.770: ERROR/GeckoAlert(3724): failed to create bitmap
07-21 12:04:17.770: ERROR/GeckoAlert(3724): java.net.MalformedURLException: Protocol not found: 
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at java.net.URL.<init>(URL.java:275)
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at java.net.URL.<init>(URL.java:159)
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at org.mozilla.gecko.AlertNotification.setCustomIcon(AlertNotification.java:94)
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at org.mozilla.gecko.GeckoAppShell.showAlertNotification(GeckoAppShell.java:906)
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:395)
07-21 12:04:17.770: ERROR/GeckoAlert(3724):     at org.mozilla.gecko.GeckoApp$2.run(GeckoApp.java:170)
07-21 12:04:17.780: INFO/GeckoAppJava(3724): Created notification ID -297100515

Comment 1

[Josh Matthews [:jdm]]

I believe this is just a logged exception that's thrown from within a try/catch block block, so it's probably not a big deal. I suppose we could just return early in the case of an empty string for the image URL.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Naoki - Since this error occurred in a broken build of Fennec, could you double check that this still happens in a known good previous build (like 7/18) updating to another known good build (like 7/22) ?

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Occurs still from 7/24 build to 7/25 build.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Alex - Can you see if we can avoid the spew?

Comment 5

[Alex Pakhotin (:alexp)]

Attachment: Fix

- Added a check for an empty icon URI
- Removed unused class member variable

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/00dcd122f9a7

Comment 8

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110728 Firefox/8.0a1 Fennec/8.0a1