673223 - Add function to obtain version of NSPR at runtime.

Status: RESOLVED FIXED

(NSPR :: NSPR, enhancement, P2)

Description

[Kai Engert (:KaiE:)]

See bug 673115 for the reasoning.

In short, allow the application to obtain the version number string from NSPR, so it can be displayed in the user interface.

This should be a runtime function, NOT compile time.
This allows us to produce correct results when e.g. using system NSPR libraries on Linux.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Patch v1

I notice that nspr.def uses new second-level version numbers whenever adding new functions, so I've added this as version 4.9

Comment 2

[Wan-Teh Chang]

Comment on attachment 547498 [details] [diff] [review]
Patch v1

Kai, thank you for the patch.  I suggest some changes.

1. mozilla/nsprpub/pr/include/prinit.h

>+NSPR_API(const char*) PR_GetLibraryVersion(void);

The function's name is PR_GetVersion.

Please add a short comment.

Please declare the function immediately after the
closely-related PR_VersionCheck function:

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/nsprpub/pr/include/prinit.h&rev=3.70&mark=98#90

2. mozilla/nsprpub/pr/src/nspr.def

> ;+} NSPR_4.7;
>+;+NSPR_4.9 {
>+;+      global:
>+                PR_GetLibraryVersion;
>+;+} NSPR_4.8;

The next NSPR release is NSPR_4.8.9.  The last line should
say NSPR_4.7.

Comment 3

[Kai Engert (:KaiE:)]

Attachment: Patch v2

Thanks for your comments, I addressed your comments.
I'm not sure I correctly understood the version number requirements in nspr.def, please let me know if another change is necessary.

Comment 4

[Kai Engert (:KaiE:)]

Attachment: Pach v3

Comment 5

[Wan-Teh Chang]

Comment on attachment 547652 [details] [diff] [review]
Pach v3

Thank you for the patch.  I made a wrong suggestion about nspr.def.
Sorry about that.

> ;+NSPR_4.8 {
> ;+	global:
> 		PR_AssertCurrentThreadOwnsLock;
> 		PR_AssertCurrentThreadInMonitor;
> ;+} NSPR_4.7;
>+;+NSPR_4.8.9 {
>+;+      global:
>+                PR_GetVersion;
>+;+} NSPR_4.7;

The last line should say NSPR_4.8.  That was my mistake.  These
symbol versions should be "chained".

Comment 6

[Kai Engert (:KaiE:)]

Attachment: Patch v4

no problem, nspr.def fixed.
thanks for reviewing

Comment 7

[Wan-Teh Chang]

Comment on attachment 547787 [details] [diff] [review]
Patch v4

r=wtc.  Thanks!

Comment 8

[Kai Engert (:KaiE:)]

Checking in pr/include/prinit.h;
/cvsroot/mozilla/nsprpub/pr/include/prinit.h,v  <--  prinit.h
new revision: 3.71; previous revision: 3.70
done
Checking in pr/src/nspr.def;
/cvsroot/mozilla/nsprpub/pr/src/nspr.def,v  <--  nspr.def
new revision: 1.16; previous revision: 1.15
done
Checking in pr/src/misc/prinit.c;
/cvsroot/mozilla/nsprpub/pr/src/misc/prinit.c,v  <--  prinit.c
new revision: 3.58; previous revision: 3.57
done