673361 - Update testSwitchPanes.js | testPreferences to navigate through Sync pane also

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

testSwitchPanes.js | testPreferences is a little outdated and needs to also take the Sync pane into consideration.

Comment 1

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/16112997

Comment 2

[Maniac Vlad Florin (:vladmaniac)]

Attachment: patch v1.0

Initial patch. 

This fix applies to all branches.

Comment 3

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 547619 [details] [diff] [review]
patch v1.0

Change looks fine from here, but I'm wondering if we should update that for each to a forEach while we're in there.

Comment 4

[Maniac Vlad Florin (:vladmaniac)]

Sure we can do that. I'll follow up with a second patch

Comment 5

[Maniac Vlad Florin (:vladmaniac)]

Attachment: patch v1.1

Added patch with geo's enhancement proposal

Comment 6

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 547622 [details] [diff] [review]
patch v1.1

Looks good to me (and I do assume gTimeout isn't used elsewhere in the file!) but I'm not in a good position to land it right now. I'll mark it check-in needed.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/252d2bff7ab6 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/6d37dacf861f (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/1996bca83742 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/ef71e3761715 (release)

Vlad, can you please check the Litmus test if it also needs an update? Thanks.