Closed Bug 673395 Opened 8 years ago Closed 8 years ago
Support Haptic of Mee
Support Haptic-Backend for MeeGo.
Comment on attachment 547672 [details] [diff] [review] Haptic for MeeGo Looks good to me, update it to latest tip, and add Patch header (bug, desc, r=me)
Attachment #547672 - Flags: review?(romaxa) → review+
(In reply to Oleg Romashin (:romaxa) from comment #1) > Looks good to me, update it to latest tip, and add Patch header (bug, desc, r=me) ^ This hasn't been done yet (patch is missing commit message & doesn't apply cleanly to trunk). Removing checkin-needed keyword - please re-add that keyword when the above's been addressed.
Comment on attachment 553248 [details] [diff] [review] Refreshed Haptic for MeeGo >--- a/dom/system/unix/Makefile.in >+++ b/dom/system/unix/Makefile.in >@@ -59,10 +59,12 @@ ifdef MOZ_MAEMO_LIBLOCATION > CPPSRCS += MaemoLocationProvider.cpp > LOCAL_INCLUDES += $(MOZ_PLATFORM_MAEMO_CFLAGS) \ > -I$(topsrcdir)/dom/src/geolocation \ > $(NULL) > endif >+CXXFLAGS += $(MOZ_QT_CFLAGS) >+CFLAGS += $(MOZ_QT_CFLAGS) > > ifdef MOZ_PLATFORM_MAEMO > CPPSRCS += nsHapticFeedback.cpp > LOCAL_INCLUDES += $(MOZ_DBUS_CFLAGS) \ > $(NULL) If this patch only touches nsHapticFeedback.cpp which is Maemo/MeeGo-specific, why are we modifying CXXFLAGS/CFLAGS unconditionally here? Shouldn't those CXXFLAGS/CFLAGS lines be inside the > ifdef MOZ_PLATFORM_MAEMO block?
Yes you right, also actual defines also need to be QT Mobility.
Comment on attachment 553290 [details] [diff] [review] Haptic for MeeGo I don't know this code particularly well, but the diff of this patch vs. previous patch looks sensible & addresses my concern. Thanks!
Attachment #553290 - Flags: review?(dholbert) → review+
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
You need to log in before you can comment on or make changes to this bug.