Closed Bug 673395 Opened 8 years ago Closed 8 years ago

Support Haptic of MeeGo/Maemo 6

Categories

(Firefox for Android Graveyard :: General, defect)

All
Maemo
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 9

People

(Reporter: jbos, Assigned: romaxa)

References

Details

(Whiteboard: [QA-])

Attachments

(1 file, 2 obsolete files)

Attached patch Haptic for MeeGo (obsolete) — Splinter Review
Support Haptic-Backend for MeeGo.
Attachment #547672 - Flags: review?(romaxa)
Blocks: 595441
Comment on attachment 547672 [details] [diff] [review]
Haptic for MeeGo

Looks good to me, update it to latest tip, and add Patch header (bug, desc, r=me)
Attachment #547672 - Flags: review?(romaxa) → review+
Keywords: checkin-needed
(In reply to Oleg Romashin (:romaxa) from comment #1)
> Looks good to me, update it to latest tip, and add Patch header (bug, desc, r=me)

^ This hasn't been done yet (patch is missing commit message & doesn't apply cleanly to trunk).

Removing checkin-needed keyword - please re-add that keyword when the above's been addressed.
Keywords: checkin-needed
Attached patch Refreshed Haptic for MeeGo (obsolete) — Splinter Review
Attachment #547672 - Attachment is obsolete: true
Attachment #553248 - Flags: review+
Comment on attachment 553248 [details] [diff] [review]
Refreshed Haptic for MeeGo

>--- a/dom/system/unix/Makefile.in
>+++ b/dom/system/unix/Makefile.in
>@@ -59,10 +59,12 @@ ifdef MOZ_MAEMO_LIBLOCATION
>         CPPSRCS         += MaemoLocationProvider.cpp
>         LOCAL_INCLUDES  += $(MOZ_PLATFORM_MAEMO_CFLAGS) \
>                            -I$(topsrcdir)/dom/src/geolocation \
>                            $(NULL)
> endif
>+CXXFLAGS	+= $(MOZ_QT_CFLAGS)
>+CFLAGS		+= $(MOZ_QT_CFLAGS)
> 
> ifdef MOZ_PLATFORM_MAEMO
> CPPSRCS += nsHapticFeedback.cpp
> LOCAL_INCLUDES  += $(MOZ_DBUS_CFLAGS) \
>                    $(NULL)


If this patch only touches nsHapticFeedback.cpp which is Maemo/MeeGo-specific, why are we modifying CXXFLAGS/CFLAGS unconditionally here?

Shouldn't those CXXFLAGS/CFLAGS lines be inside the
> ifdef MOZ_PLATFORM_MAEMO
block?
Attached patch Haptic for MeeGoSplinter Review
Yes you right, also actual defines also need to be QT Mobility.
Assignee: nobody → romaxa
Attachment #553248 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #553290 - Flags: review?(dholbert)
Comment on attachment 553290 [details] [diff] [review]
Haptic for MeeGo

I don't know this code particularly well, but the diff of this patch vs. previous patch looks sensible & addresses my concern. Thanks!
Attachment #553290 - Flags: review?(dholbert) → review+
Status: ASSIGNED → NEW
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/ea0c9306ef4a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Whiteboard: [QA?]
Whiteboard: [QA?] → [QA-]
You need to log in before you can comment on or make changes to this bug.