673417 - imgLib cleanups

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: mLoadTime has never been used

mLoadTime was added by stuart back in 2001. It hasn't as far as I can tell ever been used.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Kill more PRBools

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 547701 [details] [diff] [review]
Kill more PRBools

>diff --git a/modules/libpr0n/src/RasterImage.cpp b/modules/libpr0n/src/RasterImage.cpp
>-PRBool
>+bool
> RasterImage::ShouldAnimate()
> {
>   return Image::ShouldAnimate() && mFrames.Length() >= 2 &&
>          !mAnimationFinished;
[...]
>diff --git a/modules/libpr0n/src/RasterImage.h b/modules/libpr0n/src/RasterImage.h
> protected:
>-  PRBool ShouldAnimate();
>+  bool ShouldAnimate();
> };

ShouldAnimate overrides an inherited method (from 'Image').  You'll need to also change the method in Image & VectorImage, or this will break method-overriding.

Comment 4

[Joe Drew (not getting mail)]

Comment on attachment 547699 [details] [diff] [review]
mLoadTime has never been used

Review of attachment 547699 [details] [diff] [review]:
-----------------------------------------------------------------

I only wish I could r- this

Comment 5

[Joe Drew (not getting mail)]

Comment on attachment 547701 [details] [diff] [review]
Kill more PRBools

Review of attachment 547701 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 547701 [details] [diff] [review]
Kill more PRBools

Explicitly setting r-, to make sure Comment 3 gets addressed / noticed. :)

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/d5db87177940
http://hg.mozilla.org/mozilla-central/rev/39d0aea0cbcd

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

mwu has some mass boolification planned, so you probably don't need to do your own boolification patches.

Comment 9

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #6)
> Explicitly setting r-, to make sure Comment 3 gets addressed / noticed. :)

(/me notes that this was indeed addressed in cset d5db87177940.  Thanks! )