673553 - Move all button attributes reflection tests to test_button_attributes_reflection.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Basically do like bug 670874.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Do we want new methods in reflects.js for the 'simple' attributes checks? Do we want to keep them? (if yes, we might want to update the other attributes reflection tests and test_validation.html)

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 559781 [details] [diff] [review]
Patch v1

>--- a/content/html/content/test/forms/test_button_attributes_reflection.html
>+++ b/content/html/content/test/forms/test_button_attributes_reflection.html
>+// TODO: .form (HTMLFormElement)

Remove this line.

>+// TODO: .formAction (URL)

Make this a todo(), and note that it's weird ("except that on getting, when the content attribute is missing or its value is the empty string, the document's address must be returned instead.").

>+// .willValidate
>+// .validity
>+// .validationMessage
>+// .checkValidity()
>+// .setCustomValidity()
>+// .labels

It would probably be good to test this, but not in this file. If we do want to do this, I think I'd prefer something like

testInterface([
  ["readonly", "boolean", "willValidate"],
  ["readonly", "ValidityState", "validity"],
  ["readonly", "DOMString", "validationMessage"],
  ["readonly", "NodeList", "labels"],
], [
  ["boolean", "checkValidity"],
  ["void", "setCustomValidity", "DOMString"],
]);

(not really thought out)

>--- a/content/html/content/test/test_bug546995.html
>+++ b/content/html/content/test/test_bug546995.html
>   <select id='s'></select>
>-  <button id='b'></button>

Got a bug filed for select already?

r=me with those changes.

Comment 3

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b24ce198c411

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b24ce198c411