The default bug view has changed. See this FAQ.

We use UINT32_MAX in c++ but don't define __STDC_LIMIT_MACROS

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla8
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

The c99 standard says:

C++ implementations should define these macros only when __STDC_LIMIT_MACROS
is defined before <stdint.h> is included

and "these macros" are the limit ones like UINT32_MAX.

Most implementations ignore this, including the stdint.h used by g++-4.2 on OS X 10.5, but /usr/include/stdint.h on OS X 10.5 does require __STDC_LIMIT_MACROS to be defined and therefore our builds on 10.5 with clang fail.
Created attachment 547807 [details] [diff] [review]
patch
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #547807 - Flags: review?(jmuizelaar)

Updated

6 years ago
Attachment #547807 - Flags: review?(jmuizelaar) → review?(khuey)
Comment on attachment 547807 [details] [diff] [review]
patch

Should we be adding these to js/src's configure too?
Created attachment 548478 [details] [diff] [review]
Also change the js configure

I had missed the js configure since it is a bit different in this area. Thanks for noticing.
Attachment #547807 - Attachment is obsolete: true
Attachment #547807 - Flags: review?(khuey)
Attachment #548478 - Flags: review?(khuey)
Attachment #548478 - Flags: review?(khuey) → review+
Keywords: checkin-needed
Pushed to inbound.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/ba2bdf497934
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
Depends on: 674618
This causes warnings when building js/src on Mac. No big deal though. Patching it in bug 674618.
You need to log in before you can comment on or make changes to this bug.