The c99 standard says: C++ implementations should define these macros only when __STDC_LIMIT_MACROS is defined before <stdint.h> is included and "these macros" are the limit ones like UINT32_MAX. Most implementations ignore this, including the stdint.h used by g++-4.2 on OS X 10.5, but /usr/include/stdint.h on OS X 10.5 does require __STDC_LIMIT_MACROS to be defined and therefore our builds on 10.5 with clang fail.
Created attachment 547807 [details] [diff] [review] patch
Comment on attachment 547807 [details] [diff] [review] patch Should we be adding these to js/src's configure too?
Created attachment 548478 [details] [diff] [review] Also change the js configure I had missed the js configure since it is a bit different in this area. Thanks for noticing.
6 years ago
Pushed to inbound.
This causes warnings when building js/src on Mac. No big deal though. Patching it in bug 674618.