Closed Bug 673556 Opened 8 years ago Closed 8 years ago
We use UINT32
_MAX in c++ but don't define __STDC _LIMIT _MACROS
The c99 standard says: C++ implementations should define these macros only when __STDC_LIMIT_MACROS is defined before <stdint.h> is included and "these macros" are the limit ones like UINT32_MAX. Most implementations ignore this, including the stdint.h used by g++-4.2 on OS X 10.5, but /usr/include/stdint.h on OS X 10.5 does require __STDC_LIMIT_MACROS to be defined and therefore our builds on 10.5 with clang fail.
Assignee: nobody → respindola
Status: NEW → ASSIGNED
Attachment #547807 - Flags: review?(jmuizelaar)
Attachment #547807 - Flags: review?(jmuizelaar) → review?(khuey)
Comment on attachment 547807 [details] [diff] [review] patch Should we be adding these to js/src's configure too?
I had missed the js configure since it is a bit different in this area. Thanks for noticing.
Attachment #548478 - Flags: review?(khuey) → review+
8 years ago
Pushed to inbound.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
This causes warnings when building js/src on Mac. No big deal though. Patching it in bug 674618.
You need to log in before you can comment on or make changes to this bug.