Feature fallback on home page does not work

RESOLVED FIXED

Status

Websites
webifyme.org
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: wenzel, Assigned: brez)

Tracking

Details

(Reporter)

Description

7 years ago
Code:
<https://github.com/mozilla/webifyme/blob/5efa125/ff4/things/views.py#L34>

collages.filter() will never throw a DNE exception, it'll just be empty if it matches nothing. Therefore, if no featured collages are present, the result will just be empty, the whole try/except won't do anything.

Updated

7 years ago
Assignee: nobody → jbresnik
(Assignee)

Comment 1

7 years ago
Do we still want to return a 404 if they don't exist?
(Reporter)

Comment 2

7 years ago
Hm, no. Don't ever let the home page 404. Just don't show features if there are none to be shown. What does that look like?
(Assignee)

Comment 3

7 years ago
It looks bad - I'll just grab regular if theres no featured..

https://github.com/mozilla/webifyme/commit/da39c5606e180bb763ce2db5a10e6f127d4e6b31
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

7 years ago
Sounds good.
You need to log in before you can comment on or make changes to this bug.