Code: <https://github.com/mozilla/webifyme/blob/5efa125/ff4/things/views.py#L34> collages.filter() will never throw a DNE exception, it'll just be empty if it matches nothing. Therefore, if no featured collages are present, the result will just be empty, the whole try/except won't do anything.
Do we still want to return a 404 if they don't exist?
Hm, no. Don't ever let the home page 404. Just don't show features if there are none to be shown. What does that look like?
It looks bad - I'll just grab regular if theres no featured.. https://github.com/mozilla/webifyme/commit/da39c5606e180bb763ce2db5a10e6f127d4e6b31
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.