Should empty gallery 404?

RESOLVED FIXED

Status

--
trivial
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: wenzel, Assigned: brez)

Tracking

Details

(Reporter)

Description

8 years ago
Code: <https://github.com/mozilla/webifyme/blob/5efa125/ff4/things/views.py#L63>

This will never 404, as slicing the list of collages will never raise a DNE exception.

Either lose the try/except, or throw a 404 if the list is empty.

Updated

8 years ago
Assignee: nobody → jbresnik
(Assignee)

Comment 2

8 years ago
All set:

https://github.com/mozilla/webifyme/commit/25cd4912bcc24eb9f4465cbe65e4196ba9c4f59c
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.