Closed
Bug 673607
Opened 15 years ago
Closed 15 years ago
stop comparing apples and oranges
Categories
(Cloud Services :: Server: Core, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tarek, Assigned: tarek)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
1.01 KB,
patch
|
rmiller
:
review+
|
Details | Diff | Splinter Review |
bin/nosetests -s --with-xunit syncreg/tests
......../home/tarek/dev/hg.mozilla.org/server-reg/deps/server-core/services/util.py:338: UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
return user_name.lower().strip() != password.lower().strip()
..........
----------------------------------------------------------------------
Ran 18 tests in 12.392s
OK
This happens because the password is converted to a str, so we need to convert user name for the comparison
|
Assignee | |
Comment 1•15 years ago
|
||
This is a real bug btw, not just a warning -- see the test I added
|
||
Comment 2•15 years ago
|
||
Comment on attachment 547840 [details] [diff] [review]
Fixes the encoding issue
Review of attachment 547840 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #547840 -
Flags: review?(rmiller) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•