673622 - Descriptions should close when clicking anywhere on the page

Status: VERIFIED FIXED

(Websites :: webifyme.org, enhancement)

Description

[Fred Wenzel [:wenzel]]

The item descriptions only close when clicking on another item, or by clicking on a tiny X. I suggest they should also close when clicking elsewhere, to avoid having to aim for the tiny X.

Comment 1

[William Reynolds [:williamr]]

I agree with Fred. This would be a nice UX win. Handing this to brez.

Comment 2

[Chris More [:cmore]]

When you click on other objects in the collage, it does close the description of the previous object and open the next. The only thing that doesn't close the current description is when you click any of the share buttons or the navigation. In either case, you will be leaving the page.

The only time when this is problematic is when the object you want to click on is covered up by the current description. In that case, clicking the X is the only option.

Comment 3

[Chris More [:cmore]]

Brez: Do you know if this is possible without much code change?

Comment 4

[[:brez]]

Yea I think so - might get into some weirdness with mouseover events since there are lots of them overlapping, couldn't know for sure though until trying..

Comment 5

[[:brez]]

Should I try?

Comment 6

[William Reynolds [:williamr]]

(In reply to comment #5)
> Should I try?

Yes, it would be great to have if it's not too much trouble. I wouldn't spend more than an hour on it though. Thanks brez!

Comment 7

[[:brez]]

Found that a simple enough fix that allows you to click on the their entire panel to close (also left the Xs in to ease confusion): 

https://github.com/mozilla/webifyme/commit/d00bcdefe292fd1205c877b4f52d596c6f174fd3

Looked into clicking the entire page and would require significant edits of the existing solution (that is uses an array with each panel's close mechanism independent of others) i.e. a lot of work for little gain..

Comment 8

[krupa raj[:krupa]]

Clicking anywhere in the description panel closes it. However, clicking outside the panel, still doesn't work.

This si still an improvement from it worked previously. Marking this verified.