Add more asserts for scripts

RESOLVED FIXED in mozilla8

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: billm, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 547853 [details] [diff] [review]
patch

The findings in bug 670702 comment 8 suggest two possibilities:
- there's a script that has two owners
- a script is released into the wild, but then freed on an error path

This patch tries to detect those conditions by giving each script an owner field. Whenever we set the owner, we check that it didn't already have an owner. And when we trace it or destroy it, we validate the owner.
Attachment #547853 - Flags: review?(dmandelin)
Comment on attachment 547853 [details] [diff] [review]
patch

Review of attachment 547853 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #547853 - Flags: review?(dmandelin) → review+
(Reporter)

Updated

6 years ago
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a840cf51978a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8

Updated

6 years ago
Depends on: 674441
You need to log in before you can comment on or make changes to this bug.