Closed Bug 673628 Opened 14 years ago Closed 14 years ago

Webifyme sends malformed URLs to bitly

Categories

(Websites :: webifyme.org, defect)

Product:
Websites
Component:
webifyme.org
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: wenzel, Assigned: brez)

Details

On my local dev instance, anyway, webifyme created this URL: http://bit.ly/n6of5s Ignoring the example.com part (that's a setting, I know), there's a "href=" in there. It's caused by this line: <https://github.com/mozilla/webifyme/blob/5efa125/ff4/things/views.py#L121> which is dumped straight into the bitly API interface, but I think that's just expecting a straight URL. Not sure why the urlencode part is in the view.
Fred: I don't get the bit.ly URL box anywhere on the dev site. Can you test out the same scenerio on dev and see if there is a difference? https://webifyme-dev.allizom.org
The feature does not seem to be present on dev altogether. Is that because we're missing a bitly API key on our stage setups?
Assignee: nobody → jbresnik
Severity: critical → blocker
This was a regression - I had to use encoding for the FB like - didn't realize the same variable was being used for bitly - fixed now: https://github.com/mozilla/webifyme/commit/a14b46a1bd9c9fe54b054e10e1bf65b81bc1ccce
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
verified fixed. After completing the collage, you get linked to http://bit.ly/raUXza which loads https://webifyme-dev.allizom.org/en-US/collage/c0cba245ebea/
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.