Closed Bug 673804 Opened 10 years ago Closed 10 years ago

Utils.trace() fails since Panorama uses ES5 strict mode

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 8

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Keywords: regression)

Attachments

(1 file)

Access to function.caller is denied in strict mode.
Assignee: nobody → tim.taubert
Attached patch patch v1Splinter Review
Attachment #548038 - Flags: feedback?(raymond)
Attachment #548038 - Flags: feedback?(raymond) → feedback+
Attachment #548038 - Flags: review?(dao)
Attachment #548038 - Flags: review?(dao) → review+
http://hg.mozilla.org/mozilla-central/rev/978b92a67b6f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
(In reply to comment #4)
> http://hg.mozilla.org/mozilla-central/rev/7083160f09ac

Shouldn't have landed with DONTBUILD, as it was a code change.
(In reply to comment #5)
> (In reply to comment #4)
> > http://hg.mozilla.org/mozilla-central/rev/7083160f09ac
> 
> Shouldn't have landed with DONTBUILD, as it was a code change.

Yep, generally, you shouldn't do that. Initial blame would be on the subsequent changeset for any unforeseen consequences of your push.
Also, r=me doesn't make sense, but I guess that's a matter of taste. It's just as good as no review but seems less upfront.
(In reply to comment #6)
> > Shouldn't have landed with DONTBUILD, as it was a code change.
> 
> Yep, generally, you shouldn't do that. Initial blame would be on the
> subsequent changeset for any unforeseen consequences of your push.

Ok, sorry, I'll keep that in mind.

(In reply to comment #7)
> Also, r=me doesn't make sense, but I guess that's a matter of taste. It's
> just as good as no review but seems less upfront.

True, this was in fact just copied behavior from someone else who I thought did it right...
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.