Last Comment Bug 673804 - Utils.trace() fails since Panorama uses ES5 strict mode
: Utils.trace() fails since Panorama uses ES5 strict mode
Status: RESOLVED FIXED
: regression
Product: Firefox Graveyard
Classification: Graveyard
Component: Panorama (show other bugs)
: Trunk
: All All
: -- normal
: Firefox 8
Assigned To: Tim Taubert [:ttaubert]
:
Mentors:
Depends on:
Blocks: 673104
  Show dependency treegraph
 
Reported: 2011-07-24 12:44 PDT by Tim Taubert [:ttaubert]
Modified: 2016-04-12 14:00 PDT (History)
2 users (show)
gavin.sharp: in‑testsuite-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch v1 (2.25 KB, patch)
2011-07-24 12:48 PDT, Tim Taubert [:ttaubert]
dao+bmo: review+
raymond: feedback+
Details | Diff | Splinter Review

Description Tim Taubert [:ttaubert] 2011-07-24 12:44:48 PDT
Access to function.caller is denied in strict mode.
Comment 1 Tim Taubert [:ttaubert] 2011-07-24 12:48:05 PDT
Created attachment 548038 [details] [diff] [review]
patch v1
Comment 2 Tim Taubert [:ttaubert] 2011-07-27 21:46:49 PDT
http://hg.mozilla.org/integration/fx-team/rev/978b92a67b6f
Comment 3 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-07-28 09:58:28 PDT
http://hg.mozilla.org/mozilla-central/rev/978b92a67b6f
Comment 4 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-07-28 09:59:59 PDT
http://hg.mozilla.org/mozilla-central/rev/7083160f09ac
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2011-07-28 12:10:39 PDT
(In reply to comment #4)
> http://hg.mozilla.org/mozilla-central/rev/7083160f09ac

Shouldn't have landed with DONTBUILD, as it was a code change.
Comment 6 Dão Gottwald [:dao] 2011-07-28 13:06:25 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > http://hg.mozilla.org/mozilla-central/rev/7083160f09ac
> 
> Shouldn't have landed with DONTBUILD, as it was a code change.

Yep, generally, you shouldn't do that. Initial blame would be on the subsequent changeset for any unforeseen consequences of your push.
Comment 7 Dão Gottwald [:dao] 2011-07-28 13:10:21 PDT
Also, r=me doesn't make sense, but I guess that's a matter of taste. It's just as good as no review but seems less upfront.
Comment 8 Tim Taubert [:ttaubert] 2011-07-28 13:12:11 PDT
(In reply to comment #6)
> > Shouldn't have landed with DONTBUILD, as it was a code change.
> 
> Yep, generally, you shouldn't do that. Initial blame would be on the
> subsequent changeset for any unforeseen consequences of your push.

Ok, sorry, I'll keep that in mind.

(In reply to comment #7)
> Also, r=me doesn't make sense, but I guess that's a matter of taste. It's
> just as good as no review but seems less upfront.

True, this was in fact just copied behavior from someone else who I thought did it right...

Note You need to log in before you can comment on or make changes to this bug.