Closed Bug 673808 Opened 10 years ago Closed 10 years ago
_MAP _ is storing ns Disk Cache Record structs with uninitialized data containing bits of Fx memory
Comment on attachment 548407 [details] [diff] [review] clear new uninitialized memory r=me
Attachment #548407 - Flags: review?(bzbarsky) → review+
Tryserver is green except few intermittent failures. http://hg.mozilla.org/mozilla-central/rev/dd7d71277a15
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Please set the target milestone when checking things in....
Target Milestone: --- → mozilla8
Comment on attachment 548407 [details] [diff] [review] clear new uninitialized memory >- // Clear the new empty entries >- for (PRUint32 i = count; i < newRecordsPerBucket; ++i) >- newRecords[i].SetHashNumber(0); I think this block is still necessary when newArray + bucketIndex * newRecordsPerBucket + i < mHeader.mRecordCount since these are old entries that are no longer used and may otherwise be confused with live entries.
You need to log in before you can comment on or make changes to this bug.