Closed Bug 673817 Opened 12 years ago Closed 12 years ago

Improve auto-discovering of Android platform directory


(Firefox Build System :: General, defect)

Not set


(Not tracked)



(Reporter: mounir, Assigned: mounir)


(Whiteboard: [needs NSPR update before fixing])


(2 files, 2 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
      No description provided.
Attachment #548056 - Flags: review?(blassey.bugs)
Blocks: 673818
Comment on attachment 548056 [details] [diff] [review]
Patch v1

Review of attachment 548056 [details] [diff] [review]:

r=blassey for the non-nspr bits. Ted will need to review the nspr changes (and he may want them as a separate patch)
Attachment #548056 - Flags: review?(ted.mielczarek)
Attachment #548056 - Flags: review?(blassey.bugs)
Attachment #548056 - Flags: review+
Ted, note that I've open a bug to backport the NSPR part to NSPR trunk.
Okay, but we don't backport things, we land them in NSPR, and then take NSPR updates into mozilla-central. It's the only way to make things continue to work sanely.
Attachment #548056 - Flags: review?(ted.mielczarek)
Attached patch NSPR patch (obsolete) — Splinter Review
Attachment #548224 - Flags: review?(ted.mielczarek)
Comment on attachment 548224 [details] [diff] [review]
NSPR patch

Review of attachment 548224 [details] [diff] [review]:

Again, this needs to land in NSPR CVS.

::: nsprpub/
@@ +200,5 @@
> +
> +        if test -d "$android_platform" ; then
> +            AC_MSG_RESULT([$android_platform])
> +        else
> +            AC_MSG_ERROR([not found])

Same as the other patch, should this tell the user to use --with-android-platform?
Attachment #548224 - Flags: review?(ted.mielczarek) → review+
Attached patch NSPR patchSplinter Review
Ted, could you push this patch?
Attachment #548224 - Attachment is obsolete: true
Attachment #549435 - Flags: checkin?
Attached patch m-c patchSplinter Review
Attachment #548056 - Attachment is obsolete: true
Whiteboard: [needs review] → [needs landing]
No longer blocks: 673818
Landed the NSPR patch:
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.309; previous revision: 1.308
Checking in;
/cvsroot/mozilla/nsprpub/,v  <--
new revision: 1.311; previous revision: 1.310
Attachment #549435 - Flags: checkin? → checkin+
Attachment #549437 - Flags: checkin+
m-c patch has been pushed to inbound. This will not work until NSPR is updated in the tree.
Whiteboard: [needs landing] → [needs NSPR update before fixing][inbound]

Have to wait for NSPR merge now...
Flags: in-testsuite-
Whiteboard: [needs NSPR update before fixing][inbound] → [needs NSPR update before fixing]
The NSPR update landed:
Closed: 12 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.