Persona is no longer an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 673817 - Improve auto-discovering of Android platform directory
: Improve auto-discovering of Android platform directory
[needs NSPR update before fixing]
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Mounir Lamouri (:mounir)
: Gregory Szorc [:gps]
Depends on:
  Show dependency treegraph
Reported: 2011-07-24 16:11 PDT by Mounir Lamouri (:mounir)
Modified: 2011-08-19 09:57 PDT (History)
1 user (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (58.32 KB, patch)
2011-07-24 16:11 PDT, Mounir Lamouri (:mounir)
blassey.bugs: review+
Details | Diff | Splinter Review
NSPR patch (1.38 KB, patch)
2011-07-25 11:00 PDT, Mounir Lamouri (:mounir)
ted: review+
Details | Diff | Splinter Review
NSPR patch (1.52 KB, patch)
2011-07-29 12:04 PDT, Mounir Lamouri (:mounir)
bugspam.Callek: checkin+
Details | Diff | Splinter Review
m-c patch (3.02 KB, patch)
2011-07-29 12:04 PDT, Mounir Lamouri (:mounir)
mounir: checkin+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-07-24 16:11:41 PDT
Created attachment 548056 [details] [diff] [review]
Patch v1
Comment 1 Brad Lassey [:blassey] (use needinfo?) 2011-07-25 08:12:31 PDT
Comment on attachment 548056 [details] [diff] [review]
Patch v1

Review of attachment 548056 [details] [diff] [review]:

r=blassey for the non-nspr bits. Ted will need to review the nspr changes (and he may want them as a separate patch)
Comment 2 Mounir Lamouri (:mounir) 2011-07-25 10:24:05 PDT
Ted, note that I've open a bug to backport the NSPR part to NSPR trunk.
Comment 3 Ted Mielczarek [:ted.mielczarek] 2011-07-25 10:38:02 PDT
Okay, but we don't backport things, we land them in NSPR, and then take NSPR updates into mozilla-central. It's the only way to make things continue to work sanely.
Comment 4 Mounir Lamouri (:mounir) 2011-07-25 11:00:26 PDT
Created attachment 548224 [details] [diff] [review]
NSPR patch
Comment 5 Ted Mielczarek [:ted.mielczarek] 2011-07-29 11:31:43 PDT
Comment on attachment 548224 [details] [diff] [review]
NSPR patch

Review of attachment 548224 [details] [diff] [review]:

Again, this needs to land in NSPR CVS.

::: nsprpub/
@@ +200,5 @@
> +
> +        if test -d "$android_platform" ; then
> +            AC_MSG_RESULT([$android_platform])
> +        else
> +            AC_MSG_ERROR([not found])

Same as the other patch, should this tell the user to use --with-android-platform?
Comment 6 Mounir Lamouri (:mounir) 2011-07-29 12:04:06 PDT
Created attachment 549435 [details] [diff] [review]
NSPR patch

Ted, could you push this patch?
Comment 7 Mounir Lamouri (:mounir) 2011-07-29 12:04:25 PDT
Created attachment 549437 [details] [diff] [review]
m-c patch
Comment 8 Ted Mielczarek [:ted.mielczarek] 2011-08-08 09:12:06 PDT
Landed the NSPR patch:
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.309; previous revision: 1.308
Checking in;
/cvsroot/mozilla/nsprpub/,v  <--
new revision: 1.311; previous revision: 1.310
Comment 9 Mounir Lamouri (:mounir) 2011-08-10 05:26:33 PDT
m-c patch has been pushed to inbound. This will not work until NSPR is updated in the tree.
Comment 10 Mounir Lamouri (:mounir) 2011-08-11 04:31:50 PDT

Have to wait for NSPR merge now...
Comment 11 Ted Mielczarek [:ted.mielczarek] 2011-08-19 09:57:40 PDT
The NSPR update landed:

Note You need to log in before you can comment on or make changes to this bug.