The default bug view has changed. See this FAQ.

Improve auto-discovering of Android platform directory

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [needs NSPR update before fixing])

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 548056 [details] [diff] [review]
Patch v1
Attachment #548056 - Flags: review?(blassey.bugs)
(Assignee)

Updated

6 years ago
Blocks: 673818
Comment on attachment 548056 [details] [diff] [review]
Patch v1

Review of attachment 548056 [details] [diff] [review]:
-----------------------------------------------------------------

r=blassey for the non-nspr bits. Ted will need to review the nspr changes (and he may want them as a separate patch)
Attachment #548056 - Flags: review?(ted.mielczarek)
Attachment #548056 - Flags: review?(blassey.bugs)
Attachment #548056 - Flags: review+
(Assignee)

Comment 2

6 years ago
Ted, note that I've open a bug to backport the NSPR part to NSPR trunk.
Okay, but we don't backport things, we land them in NSPR, and then take NSPR updates into mozilla-central. It's the only way to make things continue to work sanely.
(Assignee)

Updated

6 years ago
Attachment #548056 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 4

6 years ago
Created attachment 548224 [details] [diff] [review]
NSPR patch
Attachment #548224 - Flags: review?(ted.mielczarek)
Comment on attachment 548224 [details] [diff] [review]
NSPR patch

Review of attachment 548224 [details] [diff] [review]:
-----------------------------------------------------------------

Again, this needs to land in NSPR CVS.

::: nsprpub/configure.in
@@ +200,5 @@
> +
> +        if test -d "$android_platform" ; then
> +            AC_MSG_RESULT([$android_platform])
> +        else
> +            AC_MSG_ERROR([not found])

Same as the other patch, should this tell the user to use --with-android-platform?
Attachment #548224 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 549435 [details] [diff] [review]
NSPR patch

Ted, could you push this patch?
Attachment #548224 - Attachment is obsolete: true
Attachment #549435 - Flags: checkin?
(Assignee)

Comment 7

6 years ago
Created attachment 549437 [details] [diff] [review]
m-c patch
Attachment #548056 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Whiteboard: [needs review] → [needs landing]
(Assignee)

Updated

6 years ago
No longer blocks: 673818
Landed the NSPR patch:
Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.309; previous revision: 1.308
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.311; previous revision: 1.310
done

Updated

6 years ago
Attachment #549435 - Flags: checkin? → checkin+
(Assignee)

Updated

6 years ago
Attachment #549437 - Flags: checkin+
(Assignee)

Comment 9

6 years ago
m-c patch has been pushed to inbound. This will not work until NSPR is updated in the tree.
Whiteboard: [needs landing] → [needs NSPR update before fixing][inbound]
(Assignee)

Comment 10

6 years ago
http://hg.mozilla.org/mozilla-central/rev/bfc055b710e6

Have to wait for NSPR merge now...
Flags: in-testsuite-
Whiteboard: [needs NSPR update before fixing][inbound] → [needs NSPR update before fixing]
The NSPR update landed:
http://hg.mozilla.org/mozilla-central/rev/4ab18c9e38b1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.