Closed
Bug 673826
Opened 13 years ago
Closed 13 years ago
Improve borders in various themes
Categories
(Thunderbird :: Theme, enhancement)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 10.0
People
(Reporter: squib, Assigned: squib)
Details
Attachments
(8 files, 1 obsolete file)
254.41 KB,
image/png
|
Details | |
216.22 KB,
image/png
|
Details | |
50.99 KB,
image/png
|
Details | |
57.91 KB,
image/png
|
Details | |
70.35 KB,
image/png
|
Details | |
70.28 KB,
image/png
|
Details | |
12.15 KB,
patch
|
bwinton
:
review+
andreasn
:
ui-review+
|
Details | Diff | Splinter Review |
389 bytes,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
By "various themes" here, I mean "everything but Mac", since I don't have a Mac... Most of these issues are fairly nitpicky, but they're also pretty easy to fix, so it all evens out: * XP and Linux have an unnecessary border on the right side of the 3pane * XP splitter borders look too flat * There's a 1px white space between the message header and the message body * The message header in the standalone message window has extra borders on the left and right * There's no border around the standalone message window in Windows 7
Assignee | ||
Comment 1•13 years ago
|
||
Here's a patch. Everything's pretty simple, except for the splitters on XP, which required a bit of trickery to make them look good.
Assignee: nobody → squibblyflabbetydoo
Status: NEW → ASSIGNED
Attachment #548066 -
Flags: ui-review?(nisses.mail)
Assignee | ||
Comment 2•13 years ago
|
||
Assignee | ||
Comment 3•13 years ago
|
||
Assignee | ||
Comment 4•13 years ago
|
||
Assignee | ||
Comment 5•13 years ago
|
||
Assignee | ||
Comment 6•13 years ago
|
||
Assignee | ||
Comment 7•13 years ago
|
||
Assignee | ||
Comment 8•13 years ago
|
||
Oops, I forgot to add a file to the previous patch.
Attachment #548066 -
Attachment is obsolete: true
Attachment #548066 -
Flags: ui-review?(nisses.mail)
Attachment #548073 -
Flags: ui-review?(nisses.mail)
Comment 9•13 years ago
|
||
Great work squib. Under Win7 the folderTree has also on the right a border (the treechilds are not touching the splitter). Could you also remove this one?
Assignee | ||
Comment 10•13 years ago
|
||
(In reply to comment #9) > Great work squib. Under Win7 the folderTree has also on the right a border > (the treechilds are not touching the splitter). Could you also remove this > one? I was actually thinking about going the other way with that (i.e. adding a 1px margin to the left), since I think it looks a bit cramped otherwise, and I think it's less obvious that there's a splitter to the right of the folder pane without that border. andreasn, any opinions on this?
Comment 11•13 years ago
|
||
Overall this looks great, just need to try out the folderTree in action before I decide on what behavior is best
Comment 12•13 years ago
|
||
(In reply to Andreas Nilsson (:andreasn) from comment #11) > Overall this looks great, just need to try out the folderTree in action > before I decide on what behavior is best So I didn't really come to any great conclusion on what is better here :) File explorer sidebar goes all the way to the left and leaves some space to the right, so the current behavior of the patch is good. Some air to the left would make it feel less crammed, but I don't have any super strong feelings regarding that.
Comment 13•13 years ago
|
||
Comment on attachment 548073 [details] [diff] [review] Add missing file Oh, and also ui-r+
Attachment #548073 -
Flags: ui-review?(nisses.mail) → ui-review+
Assignee | ||
Comment 14•13 years ago
|
||
Comment on attachment 548073 [details] [diff] [review] Add missing file Ok, I think this is probably review-ready. I'm sure there are more things we could do with this, but we could probably do them in a followup bug. Hopefully I'm not inundating you with too many reviews again, bwinton, but your getReviewer script has it in for you. :)
Attachment #548073 -
Flags: review?(bwinton)
Comment 15•13 years ago
|
||
Comment on attachment 548073 [details] [diff] [review] Add missing file Review of attachment 548073 [details] [diff] [review]: ----------------------------------------------------------------- On XP: * You seem to have de-centered the message header button text. On Windows 7: * It would be nice to have the same amount of padding at the end of the delete button as between the other buttons in the message header. * The Get Mail button should really line up with the border. * The space beneath the toolbar buttons should be the same as the space above the message header buttons. On Linux: * It would be nice to have the same amount of padding at the end of the delete button as between the other buttons in the message header. * The space beneath the toolbar buttons should be the same as the space above the message header buttons. Other than that, and the stuff I mention below, I like it, so r=me with those things fixed. ;) Thanks, Blake. ::: mail/themes/qute/mail/messageWindow-aero.css @@ +11,5 @@ > + * for the specific language governing rights and limitations under the > + * License. > + * > + * The Original Code is Mozilla Communicator client code, released > + * March 31, 1998. If this is actually a new file, that doesn't look right. @@ +14,5 @@ > + * The Original Code is Mozilla Communicator client code, released > + * March 31, 1998. > + * > + * The Initial Developer of the Original Code is > + * Netscape Communications Corporation. Nor this. @@ +15,5 @@ > + * March 31, 1998. > + * > + * The Initial Developer of the Original Code is > + * Netscape Communications Corporation. > + * Portions created by the Initial Developer are Copyright (C) 1998-1999 Or this. :)
Attachment #548073 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 16•13 years ago
|
||
So, I'm going to be checking this in shortly, but I wanted to address your review comments here for completeness: (In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #15) > On XP: > * You seem to have de-centered the message header button text. This is just due to the fact that the height of the text (in pixels) is odd and the height of the button is even, so it's impossible to center exactly. You can also see the de-centering in the before shot if you look at the standalone window. > On Windows 7: > * It would be nice to have the same amount of padding at the end of the > delete button as between the other buttons in the message header. I tried this, but in combination with the last bullet for Win 7, it looked strange, so I opted to make the right- and top-padding of the message header toolbar equal (or appear so). I think this looks ok, but there might be further tweaks we could make. For instance, the spacing between buttons on the main toolbar and the header toolbar is different. > * The Get Mail button should really line up with the border. Fixed. Note that this applies to all of the main toolbars (3pane, standalone window, address book). > * The space beneath the toolbar buttons should be the same as the space > above the message header buttons. See above. > On Linux: > * It would be nice to have the same amount of padding at the end of the > delete button as between the other buttons in the message header. Fixed, more or less. Like Windows 7, this was tough to get right, so I focused on making the top- and right-paddings equal. > * The space beneath the toolbar buttons should be the same as the space > above the message header buttons. Fixed, though it's only obvious that it's the same when hovering over the main toolbar buttons to see their borders. > ::: mail/themes/qute/mail/messageWindow-aero.css > @@ +11,5 @@ > > + * for the specific language governing rights and limitations under the > > + * License. > > + * > > + * The Original Code is Mozilla Communicator client code, released > > + * March 31, 1998. > > If this is actually a new file, that doesn't look right. Fixed (as well as in the other spots you mention).
Assignee | ||
Comment 17•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/96ec61738c96 If I missed (or broke) anything, please file a followup on the specific issue(s) to make tracking easier.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 10.0
Comment 18•13 years ago
|
||
Jim, it looks like you have missed a line in messageWindow-aero.css. The #messagepanebox should have a text-shadow: none; Without this the header is full of text-shadows with personas enabled.
Assignee | ||
Comment 19•13 years ago
|
||
Here's an untested fix for comment 18.
Attachment #565135 -
Flags: review?(bwinton)
Comment 20•13 years ago
|
||
Comment on attachment 565135 [details] [diff] [review] Add text-shadow: none to messageWindow-aero.css I'm actually going to ask Richard to review this, since he was the one who found the bug in the first place. :) Richard, can you make sure this fixes the bug you see and doesn't break anything else? Thanks, Blake.
Attachment #565135 -
Flags: review?(bwinton) → review?(richard.marti)
Comment 21•13 years ago
|
||
Comment on attachment 565135 [details] [diff] [review] Add text-shadow: none to messageWindow-aero.css This looks good. Now it's again the same behavior like after Bug 670639. r+
Attachment #565135 -
Flags: review?(richard.marti) → review+
Assignee | ||
Comment 22•13 years ago
|
||
Checked in: http://hg.mozilla.org/comm-central/rev/0e2c50947711
You need to log in
before you can comment on or make changes to this bug.
Description
•