67392 - CERT_ImportCAChain does not persist certs if they already exist in the temporary database

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Julien Pierre]

The title is self explicit. See certhigh.c , line 792.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Julien's right.  This code seems wrong.  

This code checks to see if the cert is already in the TEMP cert db
and if so, simply refuses to try to save it in the PERM cert db.

Perhaps it was the author's intent to check to see if it was already
in the PERM cert db, and the error was that it's checking the wrong
db.

Or, perhaps it was the author's intent to see if it's in the temp DB,
and if so, skip the steps of importing it into the temp DB and go 
straight to the step of saving the temp cert in the perm cert db,
and the error is that it is skipping it alltogether instead of 
saving in the perm cert db.  

Either way, if the cert is already in the temp cert db, this 
function won't save it in the perm.  And that just seems wrong.

The workaround is to delete the cert from the temp cert db before
calling this function.

Comment 2

[Wan-Teh Chang]

Julien, can you use the workaround that Nelson suggested?

Bob, I'm assigning this bug to you for your triage.

Comment 3

[Julien Pierre]

Wan-Teh,
I'm already using the workaround. But I'd still like to see the bug fixed in the 
future.

Comment 4

[Robert Relyea]

Attachment: Fix Shutdown crashes.

Comment 5

[Wan-Teh Chang]

Bob, I think you attached the patch to the wrong bug :)

Comment 6

[Robert Relyea]

I sure did ooops....

Comment 7

[Wan-Teh Chang]

Bob, is this fixed or should we move the target to 3.4?

Comment 8

[Robert Relyea]

Move it to 3.4

bob

Comment 9

[Wan-Teh Chang]

Changed the QA contact to Bishakha.

Comment 10

[Wan-Teh Chang]

Set target milestone to NSS 3.5.

Comment 11

[Robert Relyea]

OK, I've finally had a chance to look at this with respect to 3.4, and 3.4 no
longer checks for the cert in the temp DB before importing it.

Comment 12

[Wan-Teh Chang]

Changed target milestone to 3.4 per Bob's comment #11.