CERT_ImportCAChain does not persist certs if they already exist in the temporary database

RESOLVED FIXED in 3.4

Status

NSS
Libraries
P3
normal
RESOLVED FIXED
17 years ago
16 years ago

People

(Reporter: Julien Pierre, Assigned: Robert Relyea)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

17 years ago
The title is self explicit. See certhigh.c , line 792.
Julien's right.  This code seems wrong.  

This code checks to see if the cert is already in the TEMP cert db
and if so, simply refuses to try to save it in the PERM cert db.

Perhaps it was the author's intent to check to see if it was already
in the PERM cert db, and the error was that it's checking the wrong
db.

Or, perhaps it was the author's intent to see if it's in the temp DB,
and if so, skip the steps of importing it into the temp DB and go 
straight to the step of saving the temp cert in the perm cert db,
and the error is that it is skipping it alltogether instead of 
saving in the perm cert db.  

Either way, if the cert is already in the temp cert db, this 
function won't save it in the perm.  And that just seems wrong.

The workaround is to delete the cert from the temp cert db before
calling this function.
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows NT → All

Comment 2

17 years ago
Julien, can you use the workaround that Nelson suggested?

Bob, I'm assigning this bug to you for your triage.
Assignee: wtc → relyea
(Reporter)

Comment 3

17 years ago
Wan-Teh,
I'm already using the workaround. But I'd still like to see the bug fixed in the 
future.
(Assignee)

Comment 4

17 years ago
Created attachment 24269 [details] [diff] [review]
Fix Shutdown crashes.

Comment 5

17 years ago
Bob, I think you attached the patch to the wrong bug :)
(Assignee)

Comment 6

17 years ago
I sure did ooops....

Updated

17 years ago
Priority: -- → P3
Target Milestone: --- → 3.3

Comment 7

17 years ago
Bob, is this fixed or should we move the target to 3.4?
(Assignee)

Comment 8

17 years ago
Move it to 3.4

bob

Updated

17 years ago
Target Milestone: 3.3 → 3.4

Comment 9

16 years ago
Changed the QA contact to Bishakha.
QA Contact: sonja.mirtitsch → bishakhabanerjee

Comment 10

16 years ago
Set target milestone to NSS 3.5.
Target Milestone: 3.4 → 3.5
(Assignee)

Comment 11

16 years ago
OK, I've finally had a chance to look at this with respect to 3.4, and 3.4 no
longer checks for the cert in the temp DB before importing it.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 12

16 years ago
Changed target milestone to 3.4 per Bob's comment #11.
Target Milestone: 3.5 → 3.4
You need to log in before you can comment on or make changes to this bug.