673948 - Use display name on Questions

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P4)

Description

[James Socol [:jsocol, :james]]

+++ This bug was initially created as a clone of Bug #673947 +++

We should probably go ahead and use the display_name() helper to show a user's display name instead of their user name (when it's set) on questions and answers.

May want to wait for https://bugzilla.mozilla.org/show_bug.cgi?id=663502

Comment 1

[Scoobidiver (away)]

According to the discussion in bug 674200, the username must also be displayed with the display name.

Comment 2

[sandeep]

Hi,
I am a beginner and am looking for a good first bug. I am interested to work on this bug. So I  request you to assign this to me.

Regards,
Sai Sandeep

Comment 3

[Michael Cooper [:mythmon]]

Hi Sai,

Great! I'll assign this bug to you. If you have any questions, you can respond here or ask for help in the irc channel #sumodev on irc.mozilla.org.

Also fixing bug dependency relations.

Comment 4

[Anup Kumar [:reznord]]

It would be better if you can provide the source code details and else.

Comment 5

[Michael Cooper [:mythmon]]

Anup Allamsetty: Your message in comment 4 was very unclear to me. Can you clarify? In particular, I'm not sure who that comment was targeted at, and I'm not sure if you are asking for the details of the code for the project as a whole, or if you are asking for the code changes for showing display names in questions. Can you please clarify?

Comment 6

[Anup Kumar [:reznord]]

Mike Cooper: The location of the file to which we are supposed to make the changes.

Comment 7

[sandeep]

Mike Cooper: Hi Mike, I would like to clarify few doubts regarding the bug. Since I have to change the code to provide the patch, I want to know where I can find the source code file. Do I need to use git for it? Or can i find it in my src folder? - Thanks in advance.

-Sai Sandeep

Comment 8

[Michael Cooper [:mythmon]]

The code is available at https://github.com/mozilla/kitsune . You will need to use git for it. You can find a guide on how to download and set up a version of the code in this guide: https://kitsune.readthedocs.org/en/latest/hacking_howto.html .

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

sandeep: How're you doing on this? If you're not working on it, we should put it back in the pool for others to take.

Comment 10

[Anup Kumar [:reznord]]

Hi,

I am interested in working on this bug. So please can you assign this to me.

Thanks in Advance,

Reagrds,
A. Anup.

Comment 11

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

requesting needinfo, if no response within 3 days,  we'll assign bug to you anup

Comment 12

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Anup, are you still ready and up for this?

Comment 13

[Anup Kumar [:reznord]]

Yeah, I want to do this because there is no progress for a long time regarding this bug.

Comment 14

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Assigning you now.

Comment 15

[Anup Kumar [:reznord]]

I have a working repo of the mozilla central installed in my system. Is there a way for me where I can work with that repository?

Or I have to work on git?

Comment 16

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Anup from comment #15)
> I have a working repo of the mozilla central installed in my system. Is
> there a way for me where I can work with that repository?
> 
> Or I have to work on git?

This is separate from mozilla-central. Our code is hosted on github. You can check out our hacking documentation here:
http://kitsune.readthedocs.org/en/latest/contributors.html#help-with-hacking

Comment 17

[Ricky Rosario [:rrosario, :r1cky]]

Anup, any luck with this? Are you still interested on working on this bug?

Comment 18

[Anup Kumar [:reznord]]

For us now the semester exams are going on. SO I thought of doing it after the exams.

Comment 19

[Ricky Rosario [:rrosario, :r1cky]]

Moving to the next sprint.

Comment 20

[Alejandro López Espinosa]

Hi, 
is anyone working on this bug? 
I think i've fixed it, should i push the patch to my fork and make a pull request?
Bye

Comment 21

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

Requesting needinfo on Anup again. 

Alejandro: Feel free to make a pull request and link it if Anup doesn't respond..

Comment 22

[Alejandro López Espinosa]

Hi, here's the pull request: https://github.com/mozilla/kitsune/pull/1770
bye

Comment 23

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Alejandro López Espinosa from comment #22)
> Hi, here's the pull request: https://github.com/mozilla/kitsune/pull/1770
> bye

Hi Alejandro. There are some issues with the pull request. I commented on it. Thanks!

Comment 24

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/0f2d0eb420413e52429b01dc0a4d181479a39f99

Comment 25

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now.

Thank you Alejandro!!

Comment 26

[Alice Wyman]

This looks buggy.  The display name is now used for "last reply by" but the individual posts still show the username, as can be seen in these screenshots:
https://support.mozilla.org/en-US/gallery/image/14464
https://support.mozilla.org/en-US/gallery/image/14465
 
See discussion: https://support.mozilla.org/forums/contributors/709776

Comment 27

[Alejandro López Espinosa]

Hi,
sorry for the inconveniences, i think that i've fixed it in https://github.com/mozilla/kitsune/pull/1781

Thanks a lot alice!

Comment 28

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Alejandro López Espinosa from comment #27)
> Hi,
> sorry for the inconveniences, i think that i've fixed it in
> https://github.com/mozilla/kitsune/pull/1781
> 
> Thanks a lot alice!

That was deployed to prod right now. Thanks!