673981 - Tinderbox Push Log (TBPL) should fill page with results, even with 'pusher' parameter

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: TBPL, defect)

Description

[Jim Blandy :jimb]

When I retrieve this URL:

http://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

unless Jason has pushed something within the last 12 hours (or whatever the horizon is), I get a blank display.

It would be more useful if this always retrieved at least a screenful of results, even if it has to look further back to get them.

Comment 1

[Phil Ringnalda (:philor)]

Yeah. The problem for both this and bug 672798 is that tbpl has two very distinct things, filters and pushlog params, that are deeply intertwingled in the UI.

If you load ?rev=123abc, or less visibly if you load a tree and click the green arrow at the bottom to add 10 more pushes, you're affecting the pushlog that's loaded and then has the builds on that push or those pushes displayed.

If you press u, or toggle the Only unstarred checkbox in the Filters menu, you're applying a filter, hiding some of the stuff that's still loaded and still reloading.

Unfortunately, pusher is implemented as a filter, but it's presented in the UI as both a filter in the Filters menu, and as what seems like it would be a pushlog param by virtue of being what happens when you click the linked pusher's email address, right next to the linked date that loads the rev as a pushlog param.

Because I think tbpl has a narrow and technical enough audience to get away with things like that, I'd say (if an angel came along to write the code to do it) we could just have a pushedby pushlog param triggered by clicking the pusher's email, and retain pusher as a pusherfilter triggered by the Filter menu, but if we're going to have just one, I think we've got the wrong one. It's easy to come up with a reason to use pushedby ("I pushed three things to try, I want to watch all three of them"), but it's very hard to come up with a proper reason to use the filter - "I pushed to mozilla-central, and I'm only going to look at my push, ignoring those test jobs which run on my code for the first time on a push after me because the jobs got coalesced" is not something which we really need or want to support, and letting you watch only your try pushes by continuing to load the results of other people's pushes, and loading new pushes by other people, is not terribly helpful of us.

Comment 2

[Ed Morley [:emorley]]

This is fixed in Treeherder (once bug 1071002 is resolved).
Wontfix here since TBPL is nearing EOL.