Created attachment 548297 [details] [diff] [review]
Check the correct condition when setting a header on an XHR.
This is going to need to go on aurora as well. Marking the tracking flag to help me not forget about it after pushing to m-c.
This is a regression from bug 553888, correct?
Is there a way this fix can be verified by QA? If so, please help me with some test case/STR/guidelines.
There's a test present in the patch that is currently passing. You could try replicating that (ensure that calling xhr.setRequestHeader("foo") throws after calling xhr.send()) if you wanted.
To verify this issue open the link from comment #4. It is obvious from the code changes that mState is now checked instead of GetReadyState
(1.12 - PRUint16 state;
1.13 - rv = GetReadyState(&state);
1.14 - if (NS_FAILED(rv) || state != OPENED)
1.15 + if (!(mState & XML_HTTP_REQUEST_OPENED))
(it is already on aurora 8)