Closed Bug 6741 Opened 25 years ago Closed 25 years ago

[PP][Mac] popup menu items are not inserted correctly

Categories

(Core :: XUL, defect, P3)

PowerPC
Mac System 8.5
defect

Tracking

()

VERIFIED FIXED

People

(Reporter: Brade, Assigned: saari)

References

Details

Popup menu items on Macintosh are not being inserted properly.
For example, go to Composer.
Notice that the size popup menu on the toolbar doesn't list "-2" and "-1" when
popped up.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
This should be fixed
Status: RESOLVED → REOPENED
Reopening.
This is not fixed in my build from this morning.
Both the toolbar and the Format->Size hierarchical menu are incorrect.
Resolution: FIXED → ---
Summary: [Mac] popup menu items are not inserted correctly → [PP][Mac] popup menu items are not inserted correctly
Cool, MacOS bug. The SetMenuItemText docs specifically say it does not look for
meta characters. Guess "-" is an exception. I'll see if I can work around it.
Target Milestone: M7
Targeting M7
Workaround: insert a leading space in the xul, " -2", etc.
This apparently keeps the menu manager from incorrectly interpreting the dash,
but has no visual artifacts.

I'll talk to Tague about doing this in the code in an internationally friendly
way.
Talked to saari last night about this.  I don't see a problem with inserting a
low ascii space (32) since that is preservered in Unicode translation and pretty
much every character set.  If there are problems on the i18n side of things, let
me know and I'll take a look at it.
Target Milestone: M7 → M8
Pushing to M8
*** Bug 9391 has been marked as a duplicate of this bug. ***
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Modified the editor XUL file with the work around, as I don't want to add a
space to the beginning of every menu item (the OS does recognize it).

I think working around this in the XUL is the right answer. Marking fixed
Status: RESOLVED → REOPENED
*** Bug 7878 has been marked as a duplicate of this bug. ***
Sorry, but I don't think we can just close this because there's a bug in the OS.
You're imposing a burden on XUL writers everywhere (most of whom will never test
on Mac) that they follow some obscure rule to keep Mac users happy. It can't be
hard to find a simple solution to the problem, like converting to an em dash,
or adding a space in the C++ code.
Resolution: FIXED → ---
cc:ing self. Sorry about the noise.
Ok, I can add space, no problem, but the OS does recognize the space... so any
menu with a dash at the beginning will be indented. I can try other
characters...
Also, adding random things to the name may present internationalization
issues... Tague, other than a space, what are some safe white space characters I
can jam in safely?
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
Well, I hope "-" isn't an international sensitive character, because I just
commited the code to look for it and insert a space if needed.

Fixed again, for the first time.
Status: RESOLVED → REOPENED
Reopening. The fix for this has rendered all popup items disabled.
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Well, this was technically a different bug that just got exposed (I really don't
know why it didn't manifest earlier, very strange).

Anyway, it is fixed.
Status: RESOLVED → VERIFIED
verified on

     1999-07-09-08 MacOS 8.51
You need to log in before you can comment on or make changes to this bug.