Closed Bug 674136 Opened 13 years ago Closed 13 years ago

IonMonkey: generate MIR flags using a macro

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: rpearl, Assigned: rpearl)

Details

Attachments

(1 file)

Attached patch patch v0Splinter Review
There's a lot of MIR instruction flag code which is very repetitive (isFlag, setFlag, setNotFlag, for a variety of flags), so adding a new flag is very tedious. (This will come in handy in a forthcoming patch, where I add some new flags).

We should use a table / X-macro (I don't know the Mozilla name for it) to generate an enum of flag bit indices and accessors for each flag.
Attachment #548346 - Flags: review?(dvander)
Comment on attachment 548346 [details] [diff] [review]
patch v0

Review of attachment 548346 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #548346 - Flags: review?(dvander) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/c82778c5e535
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.