Document that module exports are frozen and immutable

RESOLVED FIXED in 1.1

Status

P3
normal
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: irakli, Assigned: wbamberg)

Tracking

unspecified
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
See Also: → bug 672199
Assignee: nobody → rFobic
Depends on: 672199
Created attachment 548428 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/219

Pointer to Github pull-request
Attachment #548428 - Flags: review?(wbamberg)
(Assignee)

Comment 2

7 years ago
The exports object is frozen inside require(), is that correct?
(Assignee)

Comment 3

7 years ago
Created attachment 548840 [details] [diff] [review]
Added a note, and a short example.

Added a note, and a short example. I think an FAQ would be good too for this, and I'll update that too, with more or less the same text, if you think this is OK.
Assignee: rFobic → wbamberg
Attachment #548428 - Attachment is obsolete: true
Attachment #548428 - Flags: review?(wbamberg)
Attachment #548840 - Flags: review?(rFobic)
Comment on attachment 548840 [details] [diff] [review]
Added a note, and a short example.

Review of attachment 548840 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
Attachment #548840 - Flags: review?(rFobic) → review+
(In reply to comment #3)
> Created attachment 548840 [details] [diff] [review] [review]
> Added a note, and a short example.
> 
> Added a note, and a short example. I think an FAQ would be good too for
> this, and I'll update that too, with more or less the same text, if you
> think this is OK.

I think it's great! Thanks!
Priority: -- → P3
Target Milestone: --- → 1.1
(Assignee)

Comment 6

7 years ago
Thanks Irakli. Landed in https://github.com/mozilla/addon-sdk/commit/4fb5bdd5e5c8b4f86bf6cc3b9dd378023224ec3b
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.