Closed
Bug 674191
Opened 13 years ago
Closed 13 years ago
Document that module exports are frozen and immutable
Categories
(Add-on SDK Graveyard :: Documentation, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
1.1
People
(Reporter: irakli, Assigned: wbamberg)
References
Details
Attachments
(1 file, 1 obsolete file)
1012 bytes,
patch
|
irakli
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•13 years ago
|
Assignee: nobody → rFobic
Reporter | ||
Comment 1•13 years ago
|
||
Pointer to Github pull-request
Reporter | ||
Updated•13 years ago
|
Attachment #548428 -
Flags: review?(wbamberg)
Assignee | ||
Comment 2•13 years ago
|
||
The exports object is frozen inside require(), is that correct?
Assignee | ||
Comment 3•13 years ago
|
||
Added a note, and a short example. I think an FAQ would be good too for this, and I'll update that too, with more or less the same text, if you think this is OK.
Assignee: rFobic → wbamberg
Attachment #548428 -
Attachment is obsolete: true
Attachment #548428 -
Flags: review?(wbamberg)
Attachment #548840 -
Flags: review?(rFobic)
Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 548840 [details] [diff] [review] Added a note, and a short example. Review of attachment 548840 [details] [diff] [review]: ----------------------------------------------------------------- Awesome!
Attachment #548840 -
Flags: review?(rFobic) → review+
Reporter | ||
Comment 5•13 years ago
|
||
(In reply to comment #3) > Created attachment 548840 [details] [diff] [review] [review] > Added a note, and a short example. > > Added a note, and a short example. I think an FAQ would be good too for > this, and I'll update that too, with more or less the same text, if you > think this is OK. I think it's great! Thanks!
Updated•13 years ago
|
Priority: -- → P3
Target Milestone: --- → 1.1
Assignee | ||
Comment 6•13 years ago
|
||
Thanks Irakli. Landed in https://github.com/mozilla/addon-sdk/commit/4fb5bdd5e5c8b4f86bf6cc3b9dd378023224ec3b
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•