Provide light embedding .jar version

VERIFIED FIXED

Status

()

Core
Embedding: APIs
--
minor
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Sebastian Späth, Assigned: Adam Lock)

Tracking

Trunk
x86
Windows 98
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
Currently the nightly Windows embedding package provides the skin etc. as single 
files in the directory structure. It would be however perfect for us embedding 
developers to provide these files as a jarred version.

So I'd have only to drop the .jar's into our embedding product and would be 
done. No fiddling how to convert the skin files from using directory structure 
to use the jars and no testing which files have to be in a jar and which can be 
removed from an embedding light version jar.
(Assignee)

Comment 1

18 years ago
Created attachment 24664 [details] [diff] [review]
Diffs to provide a lightweight embedding jar file
(Assignee)

Comment 2

18 years ago
This diff contains changes to mozilla/embedding/config which allow it to build a 
new embed.jar file. Embed.jar just contains the bits that embedders need such as 
scrollbar graphics, necko strings etc.

The changes are as follows:

New embed_jar.mn manifest file contains a list of files to put in embed.jar. 
Updated installed-chrome.txt to point at the jar file
Changes to basebuild-win to install jar dlls and embed.jar

I haven't done Unix/Linux yet.

Comments please on the approach.
Status: NEW → ASSIGNED
(Assignee)

Comment 3

18 years ago
I should add that I cutted and pasted quite liberally to produce the manifest so 
we can probably prune out about 30% of the stuff for an even smaller jar file.
(Assignee)

Comment 4

18 years ago
Created attachment 24754 [details] [diff] [review]
New patch includes Unix diffs.
(Assignee)

Comment 5

18 years ago
Hi Jud, can you review the new patch for checkin?

This patch will switch both the Win32 and Unix/Linux embedding distributions
over to using chrome stored in embed.jar. I've also added run-mozilla.sh to the
Unix distro.

Comment 6

18 years ago
excellent! r=valeski
(Assignee)

Comment 7

18 years ago
Fix is in
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
Moving API bug ownership to David Epstein.
QA Contact: mdunn → depstein

Comment 9

17 years ago
Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 10

17 years ago
Adam, I noticed that your patches included strres.js and several *Bindings.xul
(e.g. xulBindings, menulistBindings, radioBindings, etc.) in embed-jar.mn. But I
didn't see them in the build files. Are they supposed to be included? All of
these are in content/global. If it's OK, just change status back to fixed and
I'll verify/ 
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 11

17 years ago
Please verify this bug. The embed-jar.mn specifically lists what files go into 
embed.jar and there are no other places in the makefile that they'll be listed.

A number of bugs including 83393 & 90404 are covering some recent manifest 
changes.
Status: REOPENED → RESOLVED
Last Resolved: 18 years ago17 years ago
Resolution: --- → FIXED

Comment 12

17 years ago
Thanks Adam.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.