67423 - Provide light embedding .jar version

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Sebastian Späth]

Currently the nightly Windows embedding package provides the skin etc. as single 
files in the directory structure. It would be however perfect for us embedding 
developers to provide these files as a jarred version.

So I'd have only to drop the .jar's into our embedding product and would be 
done. No fiddling how to convert the skin files from using directory structure 
to use the jars and no testing which files have to be in a jar and which can be 
removed from an embedding light version jar.

Comment 1

[Adam Lock]

Attachment: Diffs to provide a lightweight embedding jar file

Comment 2

[Adam Lock]

This diff contains changes to mozilla/embedding/config which allow it to build a 
new embed.jar file. Embed.jar just contains the bits that embedders need such as 
scrollbar graphics, necko strings etc.

The changes are as follows:

New embed_jar.mn manifest file contains a list of files to put in embed.jar. 
Updated installed-chrome.txt to point at the jar file
Changes to basebuild-win to install jar dlls and embed.jar

I haven't done Unix/Linux yet.

Comments please on the approach.

Comment 3

[Adam Lock]

I should add that I cutted and pasted quite liberally to produce the manifest so 
we can probably prune out about 30% of the stuff for an even smaller jar file.

Comment 4

[Adam Lock]

Attachment: New patch includes Unix diffs.

Comment 5

[Adam Lock]

Hi Jud, can you review the new patch for checkin?

This patch will switch both the Win32 and Unix/Linux embedding distributions
over to using chrome stored in embed.jar. I've also added run-mozilla.sh to the
Unix distro.

Comment 6

[Judson Valeski]

excellent! r=valeski

Comment 7

[Adam Lock]

Fix is in

Comment 8

[Michael Dunn]

Moving API bug ownership to David Epstein.

Comment 9

[Michael Dunn]

Correction: Changing QA contact for the Embed API bugs to David Epstein.

Comment 10

[David Epstein]

Adam, I noticed that your patches included strres.js and several *Bindings.xul
(e.g. xulBindings, menulistBindings, radioBindings, etc.) in embed-jar.mn. But I
didn't see them in the build files. Are they supposed to be included? All of
these are in content/global. If it's OK, just change status back to fixed and
I'll verify/ 

Comment 11

[Adam Lock]

Please verify this bug. The embed-jar.mn specifically lists what files go into 
embed.jar and there are no other places in the makefile that they'll be listed.

A number of bugs including 83393 & 90404 are covering some recent manifest 
changes.

Comment 12

[David Epstein]

Thanks Adam.