The default bug view has changed. See this FAQ.

Simplify favicons INSERT query

RESOLVED FIXED in Firefox 8

Status

()

Firefox
Bookmarks & History
--
enhancement
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
See feature page:

  https://wiki.mozilla.org/Services/Sync/FxSync/FaviconSync

Prerequisite for Bug 428378.

Taking this for now. Will holler if I need help.
(Assignee)

Comment 1

6 years ago
Created attachment 548614 [details] [diff] [review]
Part 0: eliminate redundant OR REPLACE from insert query.

Trivial patch. Try builds:

  http://tbpl.mozilla.org/?tree=Try&rev=19657de3f84d
  http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/rnewman@mozilla.com-19657de3f84d.

Places unit tests pass locally, so let's see what try thinks...
Attachment #548614 - Flags: review?(mak77)
(Assignee)

Comment 2

6 years ago
Try looks green.
Comment on attachment 548614 [details] [diff] [review]
Part 0: eliminate redundant OR REPLACE from insert query.

Review of attachment 548614 [details] [diff] [review]:
-----------------------------------------------------------------

ah, now I remember why this was here, asyncFaviconHelpers.cpp was using this query before getting its own statementsCache, indeed it's using OR REPLACE atm.
Attachment #548614 - Flags: review?(mak77) → review+
(Assignee)

Comment 4

6 years ago
Thanks mak.

Pushed part 0, just to get some more time to bake while I work on the rest:

  http://hg.mozilla.org/services/services-central/rev/9d927d1f2ac8

Updated

6 years ago
Whiteboard: [qa-]
(Assignee)

Comment 5

6 years ago
Re-casting this bug to reflect the fact that it's landed and the rest will take a while...
Summary: Extend moz_favicons with GUID and lastModified timestamp to support Sync → Simplify favicons INSERT query
Whiteboard: [qa-] → [fixed in services][qa-]
(Assignee)

Updated

6 years ago
Blocks: 675996
http://hg.mozilla.org/mozilla-central/rev/9d927d1f2ac8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → Firefox 8
You need to log in before you can comment on or make changes to this bug.