Closed Bug 674238 Opened 9 years ago Closed 9 years ago

Simplify favicons INSERT query

Categories

(Firefox :: Bookmarks & History, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 8

People

(Reporter: rnewman, Assigned: rnewman)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

See feature page:

  https://wiki.mozilla.org/Services/Sync/FxSync/FaviconSync

Prerequisite for Bug 428378.

Taking this for now. Will holler if I need help.
Try looks green.
Comment on attachment 548614 [details] [diff] [review]
Part 0: eliminate redundant OR REPLACE from insert query.

Review of attachment 548614 [details] [diff] [review]:
-----------------------------------------------------------------

ah, now I remember why this was here, asyncFaviconHelpers.cpp was using this query before getting its own statementsCache, indeed it's using OR REPLACE atm.
Attachment #548614 - Flags: review?(mak77) → review+
Thanks mak.

Pushed part 0, just to get some more time to bake while I work on the rest:

  http://hg.mozilla.org/services/services-central/rev/9d927d1f2ac8
Whiteboard: [qa-]
Re-casting this bug to reflect the fact that it's landed and the rest will take a while...
Summary: Extend moz_favicons with GUID and lastModified timestamp to support Sync → Simplify favicons INSERT query
Whiteboard: [qa-] → [fixed in services][qa-]
Blocks: 675996
http://hg.mozilla.org/mozilla-central/rev/9d927d1f2ac8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → Firefox 8
You need to log in before you can comment on or make changes to this bug.