674323 - convert most eventutils.js functions to use SpecialPowers

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

EventUtils.js has a lot of functions that still use SpecialPowers.  This is a cleanup of everything that doesn't send and event.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: convert eventutils.js to specialPowers (1.0)

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: convert eventutils.js to specialPowers (1.5)

updated patch to fix issues on try server.  This patch allows for a green run on try server.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 548836 [details] [diff] [review]
convert eventutils.js to specialPowers (1.5)

Review of attachment 548836 [details] [diff] [review]:
-----------------------------------------------------------------

This is r- just for the getEvent stuff, the rest looks fine.

::: layout/forms/test/test_bug549170.html
@@ +33,5 @@
>  
>  function mouseHandler(aEvent)
>  {
>    gNumberOfMouseEventsCatched++;
> +  aEvent = SpecialPowers.getEvent(aEvent);

I don't like this. Can you talk to smaug about why this doesn't work without the wrapper instead of adding this hack? I don't think we should add hacks for individual tests like this.

::: testing/mochitest/specialpowers/content/specialpowers.js
@@ +97,5 @@
> +    if (aWindow == this.window)
> +      return this.DOMWindowUtils;
> +
> +    return bindDOMWindowUtils(aWindow);
> +  },

I really don't like this, but if you can't get things to work without it I guess we'll take it.

::: testing/mochitest/tests/SimpleTest/EventUtils.js
@@ +674,5 @@
> +  } else if ("SpecialPowers" in parent) {
> +    return parent.SpecialPowers.getDOMWindowUtils(aWindow);
> +  } else if (window.opener != null && "SpecialPowers" in window.opener) {
> +    return window.opener.SpecialPowers.getDOMWindowUtils(aWindow);
> +  }

This is really crazy. Can you file a followup bug on trying to sort out if we can make this less crazy? Maybe we need some platform hackers to figure out why we don't always get SpecialPowers set up correctly.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: convert eventutils.js to specialPowers (2.0)

updated patch, no getEvent stuff anymore.  Green on try server.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 565916 [details] [diff] [review]
convert eventutils.js to specialPowers (2.0)

Review of attachment 565916 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/tests/SimpleTest/EventUtils.js
@@ +530,5 @@
> +  } else if ("SpecialPowers" in parent && parent.SpecialPowers != undefined) {
> +    return parent.SpecialPowers.getDOMWindowUtils(aWindow);
> +  } else if (window.opener != null && "SpecialPowers" in window.opener) {
> +    return window.opener.SpecialPowers.getDOMWindowUtils(aWindow);
> +  }

This stuff still makes no sense to me, but I'm past caring about it.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

when we do window.open(data:...) or open up bookmark manager, we do not have access to specialpowers.  So the end result is we need to ensure all test code has access to SpecialPowers.  It would be nice to eventually clean all this up, but there are a lot of special cases.

Comment 7

[(not currently active) Ted Mielczarek]

Can we maybe open a bug to track that issue? It doesn't have to block this stuff landing, but it'd be good to figure out the root cause eventually.

Comment 8

[Josh Matthews [:jdm]]

(In reply to Joel Maher (:jmaher) from comment #6)
> when we do window.open(data:...) or open up bookmark manager, we do not have
> access to specialpowers.  So the end result is we need to ensure all test
> code has access to SpecialPowers.  It would be nice to eventually clean all
> this up, but there are a lot of special cases.

I don't believe this is true any longer after bug 681392. Can you confirm?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

I found a few scenarios were we did rely on window.parent.  I documented them in the patch and removed the window.opener clause.

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a83528577ff5

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a83528577ff5