674357 - Write a test to make sure slaves can't be allocated to both try and prod

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Slaves swapping between prod and try is a source of upload errors (wrong ssh keys), so lets ensure that the slaves lists for both have no overlap. This would be run on preproduction.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Add test and fix current dupe-age

mw32-ix-slave12 switch to try recently, but is still allowed to connect to prod. We'll have non-empty TRY_WIN64_IXS eventually, for now it's just to make the test pass.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

FWIW this is run with trial like the buildbotcustom tests, from mozilla/.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 548580 [details] [diff] [review]
Add test and fix current dupe-age

hg.mozilla.org/build/buildbot-configs/rev/ff8d867b07da
hg.mozilla.org/build/buildbot-configs/rev/116b52cf9017

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Rail gracefully volunteered to hook this up to preproduction.

Comment 5

[Rail Aliiev [:rail]]

Attachment: check staging slaves

I added 2 tests:
* test_all_prod_vs_try: compare all try slaves vs prod slaves and make sure that there is no intersection. This required some changes in prod.XSERVES
* test_prod_is_subset_of_stag: make sure that production slaves are subset of staging slaves.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 548828 [details] [diff] [review]
check staging slaves

>diff --git a/mozilla/staging_config.py b/mozilla/staging_config.py
>+TRY_WIN32      = ['try-w32-slave%02i' % x for x in range (1,37)]

This (and probably other lines) will go back down again when bug 673174 finalizes, but that's OK.

>diff --git a/mozilla/test/test_slave_allocation.py b/mozilla/test/test_slave_allocation.py

The tests I added have less coverage than what you're adding here, so go ahead and remove mine.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 548828 [details] [diff] [review]
check staging slaves

http://hg.mozilla.org/build/buildbot-configs/rev/b0c3644daa95

Comment 8

[Rail Aliiev [:rail]]

The tests are enabled in preproduction now.