674420 - 500 Internal Server on search URLs without parameters to ?query

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

This probably shouldn't block 2.1, but malformed search URLs (https://crash-stats-dev.allizom.org/query/query?build_id=on&do_query=1&query_search=signature&hang_type=hang&query_type=on&product=on&process_type=plugin&platform=on&reason=on&version=on&range_unit=on&date=07/26/2011&query) still throw 500 Internal Server Errors, like so:

[16:41:49.157] GET https://crash-stats-dev.allizom.org/query/query?build_id=on&do_query=1&query_search=signature&hang_type=hang&query_type=on&product=on&process_type=plugin&platform=on&reason=on&version=on&range_unit=on&date=07/26/2011&query [HTTP/1.1 500 Internal Server Error 413ms]

The URLs were culled from https://bugzilla.mozilla.org/show_bug.cgi?id=669965#c5 and https://bugzilla.mozilla.org/show_bug.cgi?id=669965#c11; looks like they're missing the parameter to ?query=

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

This WFM now -- was this fixed by one of Lonnen's commit(s)?

Comment 2

[Lonnen :lonnen]

r3306 / r3307 is likely what fixed it. The URLs both have query params lackin an `=`, which caused an exception prior to those check ins.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
> r3306 / r3307 is likely what fixed it. The URLs both have query params
> lackin an `=`, which caused an exception prior to those check ins.

Thanks -- mind just marking this fixed, and I'll verify?

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.  Thanks, Chris!