Closed Bug 674440 Opened 10 years ago Closed 10 years ago

remove dead code

Categories

(Toolkit :: Crash Reporting, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: espindola, Assigned: espindola)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch remove unused methods (obsolete) — Splinter Review
The attached patches remove two unused methods. This in turn lets us remove -lcrypto from the XUL link line.
Attachment #548667 - Flags: review?(ted.mielczarek)
I'll have to ask about this upstream.
Looks like a Breakpad peer had the same idea, there's an upstream patch waiting on my review as well:
http://breakpad.appspot.com/296001
That is awesome. That one is a lot more complete. Should I close this bug or can we use it to track backporting that change?
It's up to you. We can take that patch locally if it fixes a problem for you.
It does: I am trying to avoid needing 3 sdks (10.5, 10.6, 10.7) to add support for 10.7 features without dropping 10.5.

I started by trying to build with the 10.6 sdk but still having a min version of 10.5 and first error I got was the libcrypto version.

The libcrypto dylib has also been deprecated in 10.7, so it is probably a good idea to not depend on it anyway.
Assignee: nobody → respindola
Attachment #548667 - Attachment is obsolete: true
Attachment #548668 - Attachment is obsolete: true
Attachment #548667 - Flags: review?(ted.mielczarek)
Attachment #548843 - Flags: review?(ted.mielczarek)
Attachment #548843 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/293ae1bcbc12
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.