674440 - remove dead code

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: remove unused methods

The attached patches remove two unused methods. This in turn lets us remove -lcrypto from the XUL link line.

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: svn version of the patch

Comment 2

[(not currently active) Ted Mielczarek]

I'll have to ask about this upstream.

Comment 3

[(not currently active) Ted Mielczarek]

Looks like a Breakpad peer had the same idea, there's an upstream patch waiting on my review as well:
http://breakpad.appspot.com/296001

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

That is awesome. That one is a lot more complete. Should I close this bug or can we use it to track backporting that change?

Comment 5

[(not currently active) Ted Mielczarek]

It's up to you. We can take that patch locally if it fixes a problem for you.

Comment 6

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

It does: I am trying to avoid needing 3 sdks (10.5, 10.6, 10.7) to add support for 10.7 features without dropping 10.5.

I started by trying to build with the 10.6 sdk but still having a min version of 10.5 and first error I got was the libcrypto version.

The libcrypto dylib has also been deprecated in 10.7, so it is probably a good idea to not depend on it anyway.

Comment 7

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: backport of the upstream patch

Comment 8

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/293ae1bcbc12

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://hg.mozilla.org/mozilla-central/rev/293ae1bcbc12