Add a bit of logging to nsGlueLinkingOSX.cpp

RESOLVED FIXED in mozilla8

Status

()

Core
XPCOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: espindola, Assigned: espindola)

Tracking

unspecified
mozilla8
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Created attachment 548676 [details] [diff] [review]
add logging

The attached patch helped me debug why my build was not starting on 10.5. I tried to change fprintf to PR_LOG, but got undefined references to _PR_LogPrint.
Attachment #548676 - Flags: review?(mh+mozilla)
Comment on attachment 548676 [details] [diff] [review]
add logging

While you're here, I'd suggest to add similar logging to nsGlueLinkingDlopen.cpp and nsGlueLinkingWin.cpp. (And it's expected you can't use PR_LOG: nspr is not available from the xpcom standalone glue).

Note that I'm not an xpcom peer.
Attachment #548676 - Flags: review?(mh+mozilla) → review?(benjamin)
Created attachment 548782 [details] [diff] [review]
Also add logging to the dlopen case

The Windows file already has error handling, this adding logging to OS X and dlopen.
Attachment #548782 - Flags: review?
Attachment #548676 - Flags: review?(benjamin) → review+
Keywords: checkin-needed
Attachment #548782 - Flags: review? → review?(benjamin)
Let's get this landed when all of the patches have been reviewed.
Keywords: checkin-needed
Attachment #548676 - Attachment is obsolete: true
Attachment #548782 - Flags: review?(benjamin) → review?(mh+mozilla)
Mike, Benjamin r+ the previous patch. The current one adds the extra logging you asked for. Is it OK?
Attachment #548782 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Pushed to inbound.
Assignee: nobody → respindola
Keywords: checkin-needed → 4xp
Keywords: 4xp
http://hg.mozilla.org/mozilla-central/rev/d20e5ec041a4
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.