Closed
Bug 674446
Opened 13 years ago
Closed 13 years ago
Add a bit of logging to nsGlueLinkingOSX.cpp
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file, 1 obsolete file)
1.59 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
The attached patch helped me debug why my build was not starting on 10.5. I tried to change fprintf to PR_LOG, but got undefined references to _PR_LogPrint.
Attachment #548676 -
Flags: review?(mh+mozilla)
Comment 1•13 years ago
|
||
Comment on attachment 548676 [details] [diff] [review] add logging While you're here, I'd suggest to add similar logging to nsGlueLinkingDlopen.cpp and nsGlueLinkingWin.cpp. (And it's expected you can't use PR_LOG: nspr is not available from the xpcom standalone glue). Note that I'm not an xpcom peer.
Attachment #548676 -
Flags: review?(mh+mozilla) → review?(benjamin)
Assignee | ||
Comment 2•13 years ago
|
||
The Windows file already has error handling, this adding logging to OS X and dlopen.
Attachment #548782 -
Flags: review?
Updated•13 years ago
|
Attachment #548676 -
Flags: review?(benjamin) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•13 years ago
|
Attachment #548782 -
Flags: review? → review?(benjamin)
Comment 3•13 years ago
|
||
Let's get this landed when all of the patches have been reviewed.
Keywords: checkin-needed
Assignee | ||
Updated•13 years ago
|
Attachment #548676 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Attachment #548782 -
Flags: review?(benjamin) → review?(mh+mozilla)
Assignee | ||
Comment 4•13 years ago
|
||
Mike, Benjamin r+ the previous patch. The current one adds the extra logging you asked for. Is it OK?
Updated•13 years ago
|
Attachment #548782 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 5•13 years ago
|
||
Pushed to inbound.
Assignee: nobody → respindola
Keywords: checkin-needed → 4xp
Comment 6•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d20e5ec041a4
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•