glxtest.cpp fails to compile with Solaris Studio

RESOLVED FIXED in mozilla9

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

unspecified
mozilla9
x86
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 101: Error: The function "snprintf" must have a prototype.
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 166: Warning (Anachronism): Formal argument 1 of type extern "C" int(*)(_XDisplay*,XErrorEvent*) in call to XSetErrorHandler(extern "C" int(*)(_XDisplay*,XErrorEvent*)) is being passed int(*)(_XDisplay*,XErrorEvent*).
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 200: Error: The function "snprintf" must have a prototype.
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 233: Error: The function "perror" must have a prototype.
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 238: Error: The function "perror" must have a prototype.
4 Error(s) and 1 Warning(s) detected.

<cstdio> in Solaris Studio doesn't have snprintf() and perror().
#include <stdio.h> will fix that.
(Assignee)

Comment 1

6 years ago
Created attachment 548708 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #548708 - Flags: review?(karlt)
Attachment #548708 - Flags: review?(karlt) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/9e28008d9d1f
http://hg.mozilla.org/mozilla-central/rev/9e28008d9d1f
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.