Last Comment Bug 674468 - glxtest.cpp fails to compile with Solaris Studio
: glxtest.cpp fails to compile with Solaris Studio
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86 Solaris
: -- normal (vote)
: mozilla9
Assigned To: Ginn Chen
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-27 00:26 PDT by Ginn Chen
Modified: 2011-08-31 01:56 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (554 bytes, patch)
2011-07-27 00:28 PDT, Ginn Chen
karlt: review+
Details | Diff | Splinter Review

Description Ginn Chen 2011-07-27 00:26:22 PDT
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 101: Error: The function "snprintf" must have a prototype.
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 166: Warning (Anachronism): Formal argument 1 of type extern "C" int(*)(_XDisplay*,XErrorEvent*) in call to XSetErrorHandler(extern "C" int(*)(_XDisplay*,XErrorEvent*)) is being passed int(*)(_XDisplay*,XErrorEvent*).
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 200: Error: The function "snprintf" must have a prototype.
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 233: Error: The function "perror" must have a prototype.
"/export/home/ginn/work/mozilla-central/toolkit/xre/glxtest.cpp", line 238: Error: The function "perror" must have a prototype.
4 Error(s) and 1 Warning(s) detected.

<cstdio> in Solaris Studio doesn't have snprintf() and perror().
#include <stdio.h> will fix that.
Comment 1 Ginn Chen 2011-07-27 00:28:21 PDT
Created attachment 548708 [details] [diff] [review]
patch
Comment 3 Marco Bonardo [::mak] (Away 6-20 Aug) 2011-08-31 01:56:18 PDT
http://hg.mozilla.org/mozilla-central/rev/9e28008d9d1f

Note You need to log in before you can comment on or make changes to this bug.