IonMonkey: Remove free register check from MoveEmitter

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: adrake, Assigned: adrake)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
I applied the attached patch to see if we ever had a free register for cycle resolution. I ran all of my testcases for IonMonkey against both register allocators with that assert there, and not a single one ever had a register available for cycles. Some initial attempts to produce test cases to cause it to be tripped deliberately were unsuccessful.

Given this, I propose removing this untested (untestable?) mechanism entirely. Thoughts?
(Assignee)

Comment 1

7 years ago
Created attachment 548751 [details] [diff] [review]
Demo patch
Let's do it. It should remove a lot of code too.
(Assignee)

Comment 3

7 years ago
Created attachment 548945 [details] [diff] [review]
Patch v0

Strips out freeRegs everywhere I could find it, and uses of it all the way up.
(Assignee)

Updated

7 years ago
Attachment #548945 - Flags: review?(dvander)
Comment on attachment 548945 [details] [diff] [review]
Patch v0

Review of attachment 548945 [details] [diff] [review]:
-----------------------------------------------------------------

EXTREME R=me
Attachment #548945 - Flags: review?(dvander) → review+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/projects/ionmonkey/rev/b0fafd9fca12
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.