splinter is showing some new files as /dev/null

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
Extensions: Splinter
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: glob, Assigned: dkl)

Tracking

Production

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
if you do a splinter review on attachment 159923 [details] [diff] [review] the new Bugzilla/Clusion.pm is displayed as /dev/null

Index: Bugzilla/Clusion.pm
===================================================================
RCS file: Bugzilla/Clusion.pm
diff -N Bugzilla/Clusion.pm
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ Bugzilla/Clusion.pm	24 Sep 2004 01:36:59 -0000
(Assignee)

Comment 1

7 years ago
Created attachment 549216 [details] [diff] [review]
Fix incorrect detection of added/removed files in Splinter (v1)

This should fix the issue with the patch in question. Would be useful if you could also apply and then test with patches from other VCS such as git/hg/etc. It seems to still work with the patches I have tried.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Attachment #549216 - Flags: review?(glob)
(Reporter)

Comment 2

7 years ago
Comment on attachment 549216 [details] [diff] [review]
Fix incorrect detection of added/removed files in Splinter (v1)

Review of attachment 549216 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob
Attachment #549216 - Flags: review?(glob) → review+
(Assignee)

Comment 3

7 years ago
Thanks. Will be in the next code push.

Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.0
modified extensions/Splinter/web/splinter.js
Committed revision 7821.

dkl
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.