Closed Bug 674513 Opened 14 years ago Closed 14 years ago

Create flash content test pages for endurance tests

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: vladmaniac, Assigned: vladmaniac)

Details

Attachments

(1 file, 3 obsolete files)

Patch v1.3 [checked-in]
2.09 KB, patch
u279076
: review+
Details | Diff | Splinter Review
We need to have some test web pages with flash content, specifically: *embedded *flash content via <object> tab to work with firefox browser *iframes
Assignee: nobody → vlad.maniac
Status: NEW → ASSIGNED
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/16302789
Added first set of test pages for endurance tests. Those assume that we will put the pages in the litmus data repo under /litmus-data/firefox/plugins/flash folder. will correct if otherwise. Thanks!
Attachment #548763 - Flags: review?(anthony.s.hughes)
Assignee: vlad.mozbugs → nobody
Component: Mozmill Tests → Infrastructure
QA Contact: mozmill-tests → infrastructure
We cannot handle the plugin itself for flash so we need to do this using javascript. Therefore we need to modify the testpages to have multiple custom controls for videos in JS. This way we can access them with Mozmill. Cancelling r? request for this patch due to this decision.
Attachment #548763 - Flags: review?(anthony.s.hughes)
For the initial tests, we want to simply load the flash content and gather metrics based on loading content. If your original patch satisfies this role please re-mark as r?
Attachment #548763 - Flags: review?(anthony.s.hughes)
Yes, there are simple pages with flash content as required.
Moving this bug out of Infrastructure into Mozmill Tests. Test pages still belong to tests. Infrastructure is more about the backend needed for test execution.
Component: Infrastructure → Mozmill Tests
QA Contact: infrastructure → mozmill-tests
Comment on attachment 548763 [details] [diff] [review] test pages with flash content v1.0 >Bug 674513 - Create flash content test pages for endurance tests. r=ashughes, r=hskupin Henrik won't be reviewing so you can remove him from your message. >+++ b/firefox/plugins/flash/test_embedded.html Please include the type being embedded to the filename. >+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" >+"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> >+<html> >+<head> >+<title>Embedded Flash video test</title> >+</head> Make sure child nodes are indented. Title should be "Embedded Flash video (FLV) test page" >+<h1>Embedded flash video: .flv file </h1> Use the flash video file name instead of ".flv file" >+ <EMBED SRC="sample-flv-video.flv" >+ HEIGHT=480 WIDTH=640> WIDTH on its own line Can you make similar changes to the other files? I'll re-review that patch.
Attachment #548763 - Flags: review?(anthony.s.hughes) → review-
Comment on attachment 548763 [details] [diff] [review] test pages with flash content v1.0 >+<h1> Embedded flash video: .flv file </h1> >+ <EMBED SRC="sample-flv-video.flv" >+ HEIGHT=480 WIDTH=640> Please always use lowercase tags and attributes.
Additionally, if ever in doubt (since we don't really have an HTML style guide), refer to the other test HTML files we have in litmus-data.
See also the specs for XHTML/HTML if something is unclear. I should have noted that: http://www.w3.org/TR/2002/REC-xhtml1-20020801/
Assignee: nobody → vlad.mozbugs
Nits fixed - hope the new indentation looks decent
Attachment #548763 - Attachment is obsolete: true
Attachment #553427 - Flags: review?(anthony.s.hughes)
Comment on attachment 553427 [details] [diff] [review] test pages with flash content v 1.1 >+++ b/firefox/plugins/flash/test_embedded_flv_video.html Let's call this test_flv_embed.html (use a similar nomenclature for all test pages) >+ <title>Embedded Flash video (FLV) test page</title> Let's call this "FLV video via &lt;embed&gt;" (use a similar nomenclature for all test pages) >+ <h1>Embedded flash video: sample-flv-video.flv file</h1> Let's call this "Sample FLV Video:" (use a similar nomenclature for all test pages) With those changes, I can land this patch.
Attachment #553427 - Flags: review?(anthony.s.hughes) → review-
Fixed
Attachment #553427 - Attachment is obsolete: true
Attachment #553713 - Flags: review?(anthony.s.hughes)
Comment on attachment 553713 [details] [diff] [review] test pages with flash content v 1.2 >+ <h1>Sample FLV Video:</h1> >+ <embed src="sample-flv-video.flv" >+ height=480 >+ width=640> This is just a nit but I see no closing tag for <embed>. If no closing tag is necessary, please use <embed />. Since you have to update the patch anyway, please switch around width and height so it matches what you have done in the other test pages. Thanks
Attachment #553713 - Flags: review?(anthony.s.hughes) → review-
Fixed nits
Attachment #553713 - Attachment is obsolete: true
Attachment #557475 - Flags: review?(anthony.s.hughes)
Comment on attachment 557475 [details] [diff] [review] Patch v1.3 [checked-in] Looks good. Is this patch for mozmill-tests or litmus-data?
Attachment #557475 - Flags: review?(anthony.s.hughes) → review+
It's for litmus-data. We don't have a firefox sub folder in our test repository.
Comment on attachment 557475 [details] [diff] [review] Patch v1.3 [checked-in] Landed: http://hg.mozilla.org/qa/litmus-data/rev/7e5084fd3762 (default)
Attachment #557475 - Attachment description: test pages with flash content v1.3 → Patch v1.3 [checked-in]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: