Closed Bug 674531 Opened 8 years ago Closed 7 years ago

Text outside of p, div, li, pre, hx or td's are not selectable it seems

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Windows 7
defect
Not set

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: martijn.martijn, Unassigned)

References

Details

(Keywords: testcase)

Attachments

(3 files)

Attached file testcase
Certain text doesn't seem to be selectable, when they are not in a p, div, li, pre, hx or td, it seems, according to the patch from bug 661388.

+        } else if (elem instanceof Ci.nsIDOMHTMLParagraphElement ||
+                   elem instanceof Ci.nsIDOMHTMLDivElement ||
+                   elem instanceof Ci.nsIDOMHTMLLIElement ||
+                   elem instanceof Ci.nsIDOMHTMLPreElement ||
+                   elem instanceof Ci.nsIDOMHTMLHeadingElement ||
+                   elem instanceof Ci.nsIDOMHTMLTableCellElement) {

This seems rather harsh. Why should text outside of these elements not be selectable?
You are correct. Initially I did not want to start selection in buttons captions and other obviously wrong places. We should be able to make this logic better, hopefully without adding more checks.
Keywords: 64bit
Keywords: 64bit
Attached file testcase2
I tested locally what happens when removing those checks.

The selection handles still aren't invoked when long-tapping on a button. In captions, the selection handles are invoked, but I don't see why that should be disallowed.
When the caption is inside a div, then the selection handles are still invoked, even with these checks.

So I don't what the use of these checks are.
Keywords: testcase
Attached patch patchSplinter Review
Attachment #551497 - Flags: review?(mark.finkle)
Mass resolving XUL Fennec I filed to WORKSFORME. If someone still cares about this bug, please reopen.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME
Attachment #551497 - Flags: review?(mark.finkle)
You need to log in before you can comment on or make changes to this bug.