674531 - Text outside of p, div, li, pre, hx or td's are not selectable it seems

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

Certain text doesn't seem to be selectable, when they are not in a p, div, li, pre, hx or td, it seems, according to the patch from bug 661388.

+        } else if (elem instanceof Ci.nsIDOMHTMLParagraphElement ||
+                   elem instanceof Ci.nsIDOMHTMLDivElement ||
+                   elem instanceof Ci.nsIDOMHTMLLIElement ||
+                   elem instanceof Ci.nsIDOMHTMLPreElement ||
+                   elem instanceof Ci.nsIDOMHTMLHeadingElement ||
+                   elem instanceof Ci.nsIDOMHTMLTableCellElement) {

This seems rather harsh. Why should text outside of these elements not be selectable?

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

You are correct. Initially I did not want to start selection in buttons captions and other obviously wrong places. We should be able to make this logic better, hopefully without adding more checks.

Comment 2

[Martijn Wargers (dead)]

Attachment: testcase2

I tested locally what happens when removing those checks.

The selection handles still aren't invoked when long-tapping on a button. In captions, the selection handles are invoked, but I don't see why that should be disallowed.
When the caption is inside a div, then the selection handles are still invoked, even with these checks.

So I don't what the use of these checks are.

Comment 3

[Martijn Wargers (dead)]

Attachment: patch

Comment 4

[Martijn Wargers (dead)]

Mass resolving XUL Fennec I filed to WORKSFORME. If someone still cares about this bug, please reopen.