674557 - events: fix devmo_calendar_reload error

Status: VERIFIED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect)

Description

[Luke Crouch [:groovecoder]]

Cron <apache@mradm02> cd /data/devmostage/src/developer-stage9.mozilla.org/kuma; python26 manage.py cron devmo_calendar_reload > /dev/null

Traceback (most recent call last):
  File "manage.py", line 49, in <module>
    execute_manager(settings)
  File "/data/dekiwiki-stage/src/developer-stage9.mozilla.org/kuma/vendor/src/django/django/core/management/__init__.py", line 438, in execute_manager
    utility.execute()
  File "/data/dekiwiki-stage/src/developer-stage9.mozilla.org/kuma/vendor/src/django/django/core/management/__init__.py", line 379, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/data/dekiwiki-stage/src/developer-stage9.mozilla.org/kuma/vendor/src/django/django/core/management/base.py", line 191, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/data/dekiwiki-stage/src/developer-stage9.mozilla.org/kuma/vendor/src/django/django/core/management/base.py", line 220, in execute
    output = self.handle(*args, **options)
  File "/data/dekiwiki-stage/src/developer-stage9.mozilla.org/kuma/vendor/src/django-cronjobs/cronjobs/management/commands/cron.py", line 38, in handle
    registered[script](*args)
  File "/data/dekiwiki-stage/src/developer-stage9.mozilla.org/kuma/apps/devmo/cron.py", line 9, in devmo_calendar_reload
    calendar.reload()
  File "/data/dekiwiki-stage/src/developer-stage9.mozilla.org/kuma/apps/devmo/models.py", line 190, in reload
    if event_line[1] != "Conference":
IndexError: list index out of range

Comment 1

[Jay Patel [:jay]]

Luke:  Is this a quick IT fix? If so, I would like to try to get this in for 0.9.9 next week.

Comment 2

[Luke Crouch [:groovecoder]]

I'm not sure exactly. It's more than IT. Something in the doc structure has changed. I'll have to spend some time debugging it.

Comment 3

[Luke Crouch [:groovecoder]]

Change the script to check for list index existence before reference.

Comment 4

[Luke Crouch [:groovecoder]]

Traceback (most recent call last):
  File "./manage.py", line 49, in <module>
    execute_manager(settings)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/management/__init__.py", line 438, in execute_manager
    utility.execute()
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/management/__init__.py", line 379, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/management/base.py", line 191, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/core/management/base.py", line 220, in execute
    output = self.handle(*args, **options)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django-cronjobs/cronjobs/management/commands/cron.py", line 38, in handle
    registered[script](*args)
  File "/Users/lcrouch/Sites/kuma/kuma/apps/devmo/cron.py", line 9, in devmo_calendar_reload
    calendar.reload()
  File "/Users/lcrouch/Sites/kuma/kuma/apps/devmo/models.py", line 215, in reload
    event.save()
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/models/base.py", line 458, in save
    self.save_base(using=using, force_insert=force_insert, force_update=force_update)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/models/base.py", line 551, in save_base
    result = manager._insert(values, return_id=update_pk, using=using)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/models/manager.py", line 195, in _insert
    return insert_query(self.model, values, **kwargs)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/models/query.py", line 1524, in insert_query
    return query.get_compiler(using=using).execute_sql(return_id)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/models/sql/compiler.py", line 788, in execute_sql
    cursor = super(SQLInsertCompiler, self).execute_sql(None)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/models/sql/compiler.py", line 732, in execute_sql
    cursor.execute(sql, params)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/backends/util.py", line 15, in execute
    return self.cursor.execute(sql, params)
  File "/Users/lcrouch/Sites/kuma/kuma/vendor/src/django/django/db/backends/mysql/base.py", line 86, in execute
    return self.cursor.execute(query, args)
  File "/Users/lcrouch/python/kuma/lib/python2.6/site-packages/MySQLdb/cursors.py", line 175, in execute
    if not self._defer_warnings: self._warning_check()
  File "/Users/lcrouch/python/kuma/lib/python2.6/site-packages/MySQLdb/cursors.py", line 89, in _warning_check
    warn(w[-1], self.Warning, 3)
_mysql_exceptions.Warning: Data truncated for column 'people' at row 1

Comment 5

[Luke Crouch [:groovecoder]]

quick-fixed the doc so bumping this to 1.0 to make the Real Fix™

Comment 6

[Luke Crouch [:groovecoder]]

Delete date column

Make "people" and "description" fields unlimited char's

Use end date to put events into "Past"

Comment 7

[Luke Crouch [:groovecoder]]

Also, error-check the map pins

Comment 8

[Luke Crouch [:groovecoder]]

Exceptions are cleared during reload.

Events will automatically move to "Past" section based on their date.

No more "Cannot geocode this address." messages

Comment 9

[Luke Crouch [:groovecoder]]

I broke other pages. Need to make a new 'events' js bundle.

Comment 10

[Luke Crouch [:groovecoder]]

Stormy,

You can take a look at https://developer-stage9.mozilla.org/en-US/events to see the fixes/enhancements.

Comment 11

[raymond [:retornam] (inactive)]

Attachment: screenshot

re-opening as I the google map does not load. Luke,Stormy filed a bug to show the most recent past conference under the Past Conferences section and it looks like that has also not been implemented yet

Comment 12

[Luke Crouch [:groovecoder]]

https://github.com/mozilla/kuma/commit/bae688dac1bfd3be4fd05c1a97a3715bcd4617c7

Comment 13

[raymond [:retornam] (inactive)]

qa-verified-stage https://developer-stage9.mozilla.org/en-US/events

Comment 14

[raymond [:retornam] (inactive)]

verified fixed https://developer.mozilla.org/en-US/events/