674840 - Mis-positioned apptab if drag next to a tab

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[AndreiD[QA]]

Attachment: Screencast video of apptab mispositioned

Build: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0a1) Gecko/20110727 Firefox/8.0a1

Steps to reproduce:
1. Launch Firefox on a clean profile
2. Have at least one apptab and several tabs visible
3. Drag the apptab onto the window content and move it to the right of a normal tab (skipping tab animation)

Expected results:
3. The apptab thumbnail should be visible at the right of the normal tab

Actual result:
3. The dragging arrow and the apptab in its original place are simultaneously visible 


*Notes: 
This issue is present since the landing of the tab animation feature -> bug 455694. 
Is this blocking bug 455694? (see comment 304 in bug 455694)

Comment 2

[Dão Gottwald [:dao]]

Dependent, not a duplicate -- the interaction in the video is really weird.

In fact, bug 579629 as filed isn't about dragging tabs.

Comment 3

[AndreiD[QA]]

(In reply to comment #2)
> Dependent, not a duplicate -- the interaction in the video is really weird.
> 
> In fact, bug 579629 as filed isn't about dragging tabs.

Setting this as new. Thanks Dao.

Comment 4

[Frank Yan (:fryn)]

It's not a regression. Pre-tab-animation dragging also used the drop marker without moving the actual tab. I didn't handle this case for bug 455694, because it's difficult to animate elements with fixed positioning to a region using flexbox.

Comment 5

[Dão Gottwald [:dao]]

The regression here is that the app tab disappears first and the reappears in an unexpected position when you near the tab strip somewhere else. It would be less weird, albeit an incomplete detaching implementation, if the tab didn't disappear in the first place.

Comment 6

[Dão Gottwald [:dao]]

... or if it disappeared but didn't reappear unexpectedly, I guess.

Comment 7

[Frank Yan (:fryn)]

I'll try to fix this bug.
I'm less interested in fixing the non-dragging cases of bug 579629 though, so the dependency relationship might actually get inverted.

Comment 8

[Frank Yan (:fryn)]

No longer valid, since tab animations was backed out, and I'm reducing the scope of the new tab animations fix.