Closed Bug 674862 Opened 9 years ago Closed 9 years ago

nsResizerFrame may deanchor panels

Categories

(Core :: Widget, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: mak, Assigned: mak)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Since it invokes nsMenuPopupFrame::moveTo that overrides mScreenXPos and mScreenYPos even if they are -1 (thus anchored).
Attached patch patch v1.0 (obsolete) — Splinter Review
Attachment #549059 - Flags: review?(enndeakin)
Blocks: 652115
Attached patch patch v1.1Splinter Review
the comment is now useless as well
Attachment #549059 - Attachment is obsolete: true
Attachment #549059 - Flags: review?(enndeakin)
Attachment #549060 - Flags: review?(enndeakin)
Attachment #549060 - Flags: review?(enndeakin) → review+
http://hg.mozilla.org/mozilla-central/rev/f839abc8f150
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
is it possible that this is causing ForecastFox to crash the browser when hovering over the icons when ForecastFox is placed in the application bar ? 

Crashing did not occur until I started using hourly build:
http://hg.mozilla.org/mozilla-central/rev/8fb752f5e1fa

Prior hourly build based on cset: 
http://hg.mozilla.org/mozilla-central/rev/f5f1e3822540 does not crash. 

Being as its an hourly build the crash-reports will be useless.
Forgot to mention in comment #5 above, I'm using m-c win32 builds and ForecastFox and Flashblock are the only addons I use.
(In reply to comment #5)
> is it possible that this is causing ForecastFox to crash the browser when
> hovering over the icons when ForecastFox is placed in the application bar ? 

Don't think so, the changes don't seem to be able to cause any new crash that could not happen before. If you can get a stack trace with next nightly may be useful.
(In reply to comment #7)
> (In reply to comment #5)
> > is it possible that this is causing ForecastFox to crash the browser when
> > hovering over the icons when ForecastFox is placed in the application bar ? 
> 
> Don't think so, the changes don't seem to be able to cause any new crash
> that could not happen before. If you can get a stack trace with next nightly
> may be useful.

Marco, thanks for the reply.  The issue with ForecastFox and some sites was caused by https://bugzilla.mozilla.org/show_bug.cgi?id=675437 which has a fix ready for review.

Sorry for barking up the wrong tree.
You need to log in before you can comment on or make changes to this bug.