Last Comment Bug 674879 - Move Scratchpad to browser/devtools
: Move Scratchpad to browser/devtools
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 8
Assigned To: Rob Campbell [:rc] (:robcee)
:
Mentors:
Depends on:
Blocks: 703275
  Show dependency treegraph
 
Reported: 2011-07-28 05:32 PDT by Rob Campbell [:rc] (:robcee)
Modified: 2011-11-17 08:42 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
move scratchpad (13.77 KB, patch)
2011-07-28 07:39 PDT, Rob Campbell [:rc] (:robcee)
gavin.sharp: review+
mihai.sucan: review+
Details | Diff | Review
[in-fx-team] move scratchpad final (11.51 KB, patch)
2011-08-02 06:41 PDT, Rob Campbell [:rc] (:robcee)
no flags Details | Diff | Review

Description Rob Campbell [:rc] (:robcee) 2011-07-28 05:32:59 PDT
Scratchpad should live in browser/devtools.
Comment 1 Rob Campbell [:rc] (:robcee) 2011-07-28 07:39:51 PDT
Created attachment 549108 [details] [diff] [review]
move scratchpad
Comment 2 Mihai Sucan [:msucan] 2011-07-28 07:55:01 PDT
Comment on attachment 549108 [details] [diff] [review]
move scratchpad

Patch looks fine, all tests pass locally. Glad to see the Scratchpad tests in their own folder.
Comment 3 Mihai Sucan [:msucan] 2011-07-28 08:07:59 PDT
(In reply to comment #1)
> Created attachment 549108 [details] [diff] [review] [review]
> move scratchpad

How about the scratchpad.dtd/properties files? Do those continue to stay in browser/locales?
Comment 4 Rob Campbell [:rc] (:robcee) 2011-07-28 10:35:29 PDT
I think initially. When we're ready to start hosting our own locale files we should probably create a separate bug to move them all over.
Comment 5 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-08-01 14:48:36 PDT
It might be nice to flatten the test directory, I'm not sure there's much use to the second "browser" in browser/devtools/scratchpad/test/browser/ (there are unlikely to be other kinds of tests for scratchpad, and even if there are, they can co-exist in a single directory).
Comment 6 Rob Campbell [:rc] (:robcee) 2011-08-02 05:10:41 PDT
yeah, I considered that. It was problematic to do that for the webconsole, but for scratchpad it might make more sense. I will do so!

Thanks for the review.
Comment 7 Rob Campbell [:rc] (:robcee) 2011-08-02 06:41:49 PDT
Created attachment 550062 [details] [diff] [review]
[in-fx-team] move scratchpad final

flattened test directory structure from test/browser to just test.
Comment 8 Rob Campbell [:rc] (:robcee) 2011-08-02 07:35:28 PDT
Comment on attachment 550062 [details] [diff] [review]
[in-fx-team] move scratchpad final

http://hg.mozilla.org/integration/fx-team/rev/327bd5e0d804
Comment 9 Tim Taubert [:ttaubert] 2011-08-03 07:57:30 PDT
http://hg.mozilla.org/mozilla-central/rev/327bd5e0d804

Note You need to log in before you can comment on or make changes to this bug.