The default bug view has changed. See this FAQ.

Move Scratchpad to browser/devtools

RESOLVED FIXED in Firefox 8

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Scratchpad should live in browser/devtools.
(Assignee)

Comment 1

6 years ago
Created attachment 549108 [details] [diff] [review]
move scratchpad
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #549108 - Flags: review?(mihai.sucan)
Attachment #549108 - Flags: review?(gavin.sharp)
Comment on attachment 549108 [details] [diff] [review]
move scratchpad

Patch looks fine, all tests pass locally. Glad to see the Scratchpad tests in their own folder.
Attachment #549108 - Flags: review?(mihai.sucan) → review+
(In reply to comment #1)
> Created attachment 549108 [details] [diff] [review] [review]
> move scratchpad

How about the scratchpad.dtd/properties files? Do those continue to stay in browser/locales?
(Assignee)

Comment 4

6 years ago
I think initially. When we're ready to start hosting our own locale files we should probably create a separate bug to move them all over.
Attachment #549108 - Flags: review?(gavin.sharp) → review+
It might be nice to flatten the test directory, I'm not sure there's much use to the second "browser" in browser/devtools/scratchpad/test/browser/ (there are unlikely to be other kinds of tests for scratchpad, and even if there are, they can co-exist in a single directory).
(Assignee)

Comment 6

6 years ago
yeah, I considered that. It was problematic to do that for the webconsole, but for scratchpad it might make more sense. I will do so!

Thanks for the review.
(Assignee)

Comment 7

6 years ago
Created attachment 550062 [details] [diff] [review]
[in-fx-team] move scratchpad final

flattened test directory structure from test/browser to just test.
Attachment #549108 - Attachment is obsolete: true
(Assignee)

Comment 8

6 years ago
Comment on attachment 550062 [details] [diff] [review]
[in-fx-team] move scratchpad final

http://hg.mozilla.org/integration/fx-team/rev/327bd5e0d804
Attachment #550062 - Attachment description: move scratchpad final → [in-fx-team] move scratchpad final
(Assignee)

Updated

6 years ago
Whiteboard: [fixed-in-fx-team]
(Assignee)

Updated

6 years ago
Target Milestone: --- → Firefox 8
http://hg.mozilla.org/mozilla-central/rev/327bd5e0d804
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Blocks: 703275
You need to log in before you can comment on or make changes to this bug.