674879 - Move Scratchpad to browser/devtools

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

Scratchpad should live in browser/devtools.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Attachment: move scratchpad

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 549108 [details] [diff] [review]
move scratchpad

Patch looks fine, all tests pass locally. Glad to see the Scratchpad tests in their own folder.

Comment 3

[Mihai Sucan [:msucan]]

(In reply to comment #1)
> Created attachment 549108 [details] [diff] [review] [review]
> move scratchpad

How about the scratchpad.dtd/properties files? Do those continue to stay in browser/locales?

Comment 4

[Rob Campbell [:rc] (:robcee)]

I think initially. When we're ready to start hosting our own locale files we should probably create a separate bug to move them all over.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

It might be nice to flatten the test directory, I'm not sure there's much use to the second "browser" in browser/devtools/scratchpad/test/browser/ (there are unlikely to be other kinds of tests for scratchpad, and even if there are, they can co-exist in a single directory).

Comment 6

[Rob Campbell [:rc] (:robcee)]

yeah, I considered that. It was problematic to do that for the webconsole, but for scratchpad it might make more sense. I will do so!

Thanks for the review.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Attachment: [in-fx-team] move scratchpad final

flattened test directory structure from test/browser to just test.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 550062 [details] [diff] [review]
[in-fx-team] move scratchpad final

http://hg.mozilla.org/integration/fx-team/rev/327bd5e0d804

Comment 9

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/327bd5e0d804