Closed Bug 674879 Opened 9 years ago Closed 9 years ago

Move Scratchpad to browser/devtools

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 8

People

(Reporter: rcampbell, Assigned: rcampbell)

References

Details

Attachments

(1 file, 1 obsolete file)

Scratchpad should live in browser/devtools.
Attached patch move scratchpad (obsolete) — Splinter Review
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
Attachment #549108 - Flags: review?(mihai.sucan)
Attachment #549108 - Flags: review?(gavin.sharp)
Comment on attachment 549108 [details] [diff] [review]
move scratchpad

Patch looks fine, all tests pass locally. Glad to see the Scratchpad tests in their own folder.
Attachment #549108 - Flags: review?(mihai.sucan) → review+
(In reply to comment #1)
> Created attachment 549108 [details] [diff] [review] [review]
> move scratchpad

How about the scratchpad.dtd/properties files? Do those continue to stay in browser/locales?
I think initially. When we're ready to start hosting our own locale files we should probably create a separate bug to move them all over.
Attachment #549108 - Flags: review?(gavin.sharp) → review+
It might be nice to flatten the test directory, I'm not sure there's much use to the second "browser" in browser/devtools/scratchpad/test/browser/ (there are unlikely to be other kinds of tests for scratchpad, and even if there are, they can co-exist in a single directory).
yeah, I considered that. It was problematic to do that for the webconsole, but for scratchpad it might make more sense. I will do so!

Thanks for the review.
flattened test directory structure from test/browser to just test.
Attachment #549108 - Attachment is obsolete: true
Comment on attachment 550062 [details] [diff] [review]
[in-fx-team] move scratchpad final

http://hg.mozilla.org/integration/fx-team/rev/327bd5e0d804
Attachment #550062 - Attachment description: move scratchpad final → [in-fx-team] move scratchpad final
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 8
http://hg.mozilla.org/mozilla-central/rev/327bd5e0d804
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.