67502 - psm-glue ui handler crashes when there is no nsIChannelSecurityInfo associated with password request

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Javier Delgadillo]

The new password handler code in psm-glue assumes there will always be a
nsIChannelSecurityInfo when a password request comes in.  This is not true.  The
password request may come from SDR, PKCS12, or Keygen.  

So the psm-glue code needs to handle the case where the nsIChannelSecurityInfo
is not present.

Patch coming shortly.

Comment 1

[Javier Delgadillo]

Attachment: Enable default case if no nsIChannelSecurityInfo present

Comment 2

[Terry Hayes]

r=thayes

Comment 3

[Javier Delgadillo]

Attachment: Newer patch with some mods asked for by thayes.

Comment 4

[Brian Ryner (not reading)]

Well, ideally we want to stop using the dialog service... we should figure out
how to get the right nsIPrompt, somehow.

Comment 5

[Javier Delgadillo]

In pipnss yes.  But I'm not gonna spend the time to do that for psm-glue.

Comment 6

[Scott MacGregor]

is it safe to say that we are NOT on the UI thread and that's why the patch uses
a proxied service for the dialog service?

If that is indeed true sr=mscott

otherwise, let's not create a proxied service unless we need to.

Comment 7

[Javier Delgadillo]

We are not on the UI thread here.  We get lots of assertions if we don't proxy.

Comment 8

[Javier Delgadillo]

Fix checked in.

Comment 9

[Javier Delgadillo]

Forgot to mark FIXED last time through.

Comment 10

[Ian Tommins ('thelem')]

*** Bug 67156 has been marked as a duplicate of this bug. ***

Comment 11

[John Unruh]

Verified. Works for me on WinNT, Mac and Linux Mozilla builds.

Comment 12

[Jure Repinc (JLP)]

Looks fixed here.
Mozilla 2001020704 on Windows 2000 SP1 on PC.

Comment 13

[John Unruh]

*** Bug 67335 has been marked as a duplicate of this bug. ***