675082 - Reduce the "Required properites[sic]" noise in the logs

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Lonnen :lonnen]

85% (2443299 lines / 2852556 total lines) of our Kohanna log file on stage are alerts for "alert: Required properites are missing from Could not find changeInRank - versions, versions_count". Another 12% (337219 line / 2852556 total lines) are for other forms of "alert: Require properites".

We should fix whatever is causing these, or if it is not a bug, prevent it from logging. The added noise can make it difficult to debug errors.

Comment 1

[Robert Kaiser]

Sounds bad if you are not following the proper rites. :P

Comment 2

[Robert Helmer [:rhelmer]]

Jabba noticed it a while back in bug 628326 too

Comment 4

[Lonnen :lonnen]

I dug into this and found out that the two properties causing most of the problems were added as part of a large (206 changed files with 14,112 additions and 8,611 deletions) change almost a year ago. Every row result from every call to the 201010/topcrash/sig/trend service is checked for certain properties and these two props are always missing.

I looked at the code paths that might use this variable down the line but didn't find anywhere using the keys causing the problems. Similar variable names are used all over the app but I think I checked them all and determined them to be unrelated. After my changes topcrashers still loads, as does the csv output, so I'm confident that these changes won't cause other problems.


rhelmer: r?
https://github.com/mozilla/socorro/pull/14

Comment 5

[Lonnen :lonnen]

Close that request because of the bad history stuff. 

rhelmer: r?
https://github.com/mozilla/socorro/pull/25

Comment 6

[Robert Helmer [:rhelmer]]

merged https://github.com/mozilla/socorro/commit/96061c28405f7c65a322121923809b00a91c44e7