Report JIT code regions to valgrind-based tools

NEW
Unassigned

Status

()

Core
JavaScript Engine
7 years ago
4 years ago

People

(Reporter: sfink, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I believe valgrind now has an API for reporting JIT code regions. This would remove the need for --smc-check=all.
Created attachment 559734 [details] [diff] [review]
Inform valgrind of mjitted code release/update

I'm not sure if this handles the regex JIT, and it definitely does not handle the trace JIT, so --smc-check=all-non-file (if available) or --smc-check=all is still required.

This patch hooks into the generic js::Probes::JITWatcher interface, which is total overkill for this purpose. I did it that way because I plan to add another client request to register function names with JITted code regions, but it turns out it hasn't been implemented in valgrind yet. See https://bugs.kde.org/show_bug.cgi?id=203380
Created attachment 559789 [details] [diff] [review]
Inform valgrind of mjitted code release/update

Rebased to use Probes::startEngine instead of Probes::createRuntime since vg is looking at the whole process's address space
Attachment #559734 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Assignee: general → nobody
You need to log in before you can comment on or make changes to this bug.