675106 - Clean up lots of test support cruft that's being replicated everywhere

Status: RESOLVED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Toby Elliott [:telliott]]

There's a lot of 

    cfg = RawConfigParser()
    cfg.read(config)

    # loading loggers
    if cfg.has_section('loggers'):
        fileConfig(_INI_FILE)

    here = {'here': os.path.dirname(os.path.realpath(config))}
    config = dict([(key, value % here)for key, value in
                   cfg.items('DEFAULT') + cfg.items('app:main')])
    config = convert_config(config)
    storage = SyncStorage.get_from_config(config, 'storage')
    auth = ServicesAuth.get_from_config(config, 'auth')

and finding root directores, etc, floating around in test supports. The code above needs to go (and if we need functionality there, we should build it into the Config object). The rest should have as much repetition as possible pulled into server-core/tests/support

Comment 1

[Rob Miller [:rmiller]]

Attachment: server-core TestEnv refactor

Comment 2

[Rob Miller [:rmiller]]

Attachment: server-reg using new TestEnv

Comment 3

[Rob Miller [:rmiller]]

Attachment: server-sreg use new TestEnv

Comment 4

[Rob Miller [:rmiller]]

Attachment: server-storage using new TestEnv

Comment 5

[Rob Miller [:rmiller]]

Attachment: account-portal using new TestEnv

Comment 6

[Toby Elliott [:telliott]]

Comment on attachment 551118 [details] [diff] [review]
server-core TestEnv refactor

I'm r+ on this as a refactoring. Looking forward to what gets built on from here.

Comment 7

[Rob Miller [:rmiller]]

Attachment: server-core TestEnv refactor

Comment 8

[Rob Miller [:rmiller]]

Attachment: server-reg using new TestEnv

Comment 9

[Rob Miller [:rmiller]]

Attachment: server-storage using new TestEnv

Comment 10

[Rob Miller [:rmiller]]

Attachment: account-portal using new TestEnv

Comment 11

[Toby Elliott [:telliott]]

Comment on attachment 553908 [details] [diff] [review]
server-reg using new TestEnv

This is fine for now, but I think a goal should be to get rid of this entirely.

Comment 12

[Toby Elliott [:telliott]]

Comment on attachment 553911 [details] [diff] [review]
account-portal using new TestEnv

You cleaned up my flake8 protests. Boo ;)

Comment 13

[Rob Miller [:rmiller]]

finally got all of the components using the same config loading setup, got rid of lots of duplicate code

Comment 14

[Tarek Ziadé (:tarek)]

Comment on attachment 553910 [details] [diff] [review]
server-storage using new TestEnv

Looks like initenv() itself could be removed -- the test could use TestEnv directly, or maybe be a base TestCase class we can inherit from.

Comment 15

[Tarek Ziadé (:tarek)]

Comment on attachment 553911 [details] [diff] [review]
account-portal using new TestEnv



Without this fix,accountportal_test.cfg was not used.

Toby maybe you want to double-check the behavior there now


>--- a/tests.ini	Wed Aug 17 10:03:42 2011 +0200
>+++ b/tests.ini	Wed Aug 17 14:33:05 2011 -0700
>@@ -1,7 +1,6 @@
> [DEFAULT]
> debug = True
> translogger = False
>-extends = etc/accountportal_test.cfg
> 
> [server:main]
> use = egg:Paste#http
>@@ -10,6 +9,7 @@
> 
> [app:main]
> use = egg:AccountPortal
>+configuration = file:%(here)s/etc/accountportal_test.cfg
> 
> # Logging configuration
> [loggers]