675253 - Localize KB Helpfulness Votes Chart labels

Status: VERIFIED FIXED

(support.mozilla.org :: Localization, task)

Description

[Scoobidiver (away)]

The following labels are not localizable:
From, To, Zoom, 1m, 3m, 6m, YTD, 1y, All, dates

Comment 1

[Tanay Gavankar [:tgavankar]]

Done in https://github.com/jsocol/kitsune/commit/5beaa02.

Comment 2

[Rebecca Billings [:rbillings]]

Verified in verbatim that these terms are now localizable: seconds, no votes data, error loading chart, helpfulness votes, votes. I could not find the specific terms Scoobidiver mentioned above- please re-open if those items aren't fixed as expected.

Comment 3

[Scoobidiver (away)]

(In reply to Rebecca Billings from comment #2)
> Verified in verbatim that these terms are now localizable: seconds, no votes
> data, error loading chart, helpfulness votes, votes.
These terms were already localizable before this bug.

Comment 4

[Rebecca Billings [:rbillings]]

The new translation terms I see in the commit are not displaying on the verbatim instance for testing: https://localize.mozilla.org/xx_testing/sumo/LC_MESSAGES/

Please add steps to verify.

Comment 5

[Tanay Gavankar [:tgavankar]]

I'm not sure how verbatim works - I just wrap all my l10n strings in a gettext(). r1cky mentioned that jsocol runs the gettext js extraction once a week - maybe it hasn't been run yet?

Comment 6

[Rebecca Billings [:rbillings]]

Right now verbatim does not display the next terms on my test link- and no one is familiar with verbatim. There are no alternate ways to verify. I'm marking as verified, but please re-open after the release on 8/9 if the terms do not become eligible for translation.

Comment 7

[Scoobidiver (away)]

Helpfulness vote charts are no longer displayed in support.allizom.org (maybe a pref has been set to 0 or one single helpful vote is not enough), so I can't verify.

Comment 8

[Tanay Gavankar [:tgavankar]]

There was a flag that had to be set - should be enabled on allizom now.

Comment 9

[Scoobidiver (away)]

I filed bug 677018 for strings already localized.

Comment 10

[Scoobidiver (away)]

The short month format and MM-DD-YYYY are not localizable.
See:
https://support.allizom.org/hu/kb/Priv%C3%A1t%20b%C3%B6ng%C3%A9sz%C3%A9s/history

Date formats are already managed in the article history so why adding strings in Verbatim such as January, February,..., Monday, Tuesday...

Comment 11

[James Socol [:jsocol, :james]]

(In reply to Scoobidiver from comment #10)
> Date formats are already managed in the article history so why adding
> strings in Verbatim such as January, February,..., Monday, Tuesday...

Because these are localized in JavaScript, not Python, and so don't have access to all the Python libraries and support for date l10n.

Comment 12

[Tanay Gavankar [:tgavankar]]

I believe the MM-DD-YYYY is hardcoded into highcharts, so it may not be possible to localize it at all. 

However, that only appears on clicking, and when it's not focused it reverts to a standard date string (which should get localized).

Comment 13

[Scoobidiver (away)]

(In reply to Tanay Gavankar [:tgavankar] from comment #12)
> However, that only appears on clicking, and when it's not focused it reverts
> to a standard date string (which should get localized).
It's an ISO 8601 date format that appears while clicking in one of the two date fields. I am OK with that.

But selecting a day in the chart or unclicking the date fields make the today's date looks like: Aug 9, 2011 instead of 9 shortMonth 2011 or 9.8.2011 or 9/8/2011 or 2011.08.09 and so on depending on the locale.

Comment 14

[James Socol [:jsocol, :james]]

(In reply to Scoobidiver from comment #13)
> But selecting a day in the chart or unclicking the date fields make the
> today's date looks like: Aug 9, 2011 instead of 9 shortMonth 2011 or
> 9.8.2011 or 9/8/2011 or 2011.08.09 and so on depending on the locale.

This is an open problem we haven't solved in JS yet. We have date formats available but no method yet to actually use them. I am not OK with holding this bug open for this--especially since highcharts may well not support internationalized date formats at this time.

If this is the only thing holding this open, let's please close this and put it back in 08-09. If there are other issues, we can get them fixed for next week.

Comment 15

[Scoobidiver (away)]

(In reply to James Socol [:jsocol, :james] from comment #14)
> If there are other issues, we can get them fixed for next week.
I was wrong about the short month format in comment 10 because in Hungarian, August is translated in Augusztus.
Nevertheless, I see another problem about month: they are truncated to 3 letters so in some languages several truncated months can have the same abbreviations.
If months are only used by their abbreviations in charts, it's better to use month abbreviation strings in Verbatim.

Example in French:
July is translated in "Juillet" but its abbreviation is "Jul", June is translated in "Juin" but its abbreviation is "Jun". See http://fr.wikipedia.org/wiki/Mois#Abr.C3.A9viations

Comment 16

[James Socol [:jsocol, :james]]

(In reply to Scoobidiver from comment #15)
> Nevertheless, I see another problem about month: they are truncated to 3
> letters so in some languages several truncated months can have the same
> abbreviations.

Let's file a follow-up to that. I don't know if we can change it or not.

If that's the only thing still open here, let's leave this closed in 8/9, where the work was done.