Closed Bug 675286 Opened 13 years ago Closed 13 years ago

stop running debsign on non en-US, multi maemo-gtk releases

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: lsblakk, Assigned: mozilla)

References

Details

Attachments

(3 files)

since we only do en-US and multi now, make debsign more efficient to match.
Assignee: lsblakk → aki
also switches the config file type to .py, and fixes a bug with that (fh.close()).
Attachment #550107 - Flags: review?(lsblakk)
Comment on attachment 550107 [details] [diff] [review]
change mozharness to use mozilla-{beta,release} and only do en-US and multi

Review of attachment 550107 [details] [diff] [review]:
-----------------------------------------------------------------

right on, yay for cleaning up and fixing bugs at the same time
Attachment #550107 - Flags: review?(lsblakk) → review+
Attachment #550106 - Flags: review?(lsblakk) → review+
Comment on attachment 550107 [details] [diff] [review]
change mozharness to use mozilla-{beta,release} and only do en-US and multi

http://hg.mozilla.org/build/mozharness/rev/78d7231266f0
Attachment #550107 - Flags: checked-in+
Comment on attachment 550106 [details] [diff] [review]
change debsign masters to use mozilla-{beta,release}

http://hg.mozilla.org/build/buildbot-configs/rev/7d22e76577b4

Ran a staging deb sign job which only did en-US and multi, and went green.
Attachment #550106 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Also reconfiged pmm:8011.
Fennec 6.0b5 failed:
ERROR: Can't find deb_repos/release_mozilla-beta.json in ['.', '/builds/scratchbox/users/cltbld/home/cltbld/deb-mozilla-beta/scripts/../configs', '/builds/scratchbox/users/cltbld/home/cltbld/deb-mozilla-beta/scripts/../../configs']!
Traceback (most recent call last):
  File "scripts/signdebs.py", line 298, in <module>
    debSigner = MaemoDebSigner()
  File "scripts/signdebs.py", line 59, in __init__
    require_config_file=require_config_file)
  File "/builds/scratchbox/users/cltbld/home/cltbld/deb-mozilla-beta/mozharness/base/script.py", line 589, in __init__
    super(MercurialScript, self).__init__(**kwargs)
  File "/builds/scratchbox/users/cltbld/home/cltbld/deb-mozilla-beta/mozharness/base/script.py", line 49, in __init__
    **kwargs)
  File "/builds/scratchbox/users/cltbld/home/cltbld/deb-mozilla-beta/mozharness/base/config.py", line 198, in __init__
    self.parse_args()
  File "/builds/scratchbox/users/cltbld/home/cltbld/deb-mozilla-beta/mozharness/base/config.py", line 336, in parse_args
    if key in defaults and value == defaults[key] and key in self._config:
TypeError: argument of type 'NoneType' is not iterable

Patch incoming
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Use *.py configsSplinter Review
Attachment #550675 - Flags: review?(bhearsum)
Attachment #550675 - Flags: review?(bhearsum) → review+
worked fine.
Status: REOPENED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: