remove --strip-xpi option

RESOLVED FIXED in 1.3

Status

Add-on SDK
General
P3
normal
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: warner, Assigned: warner)

Tracking

unspecified

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Created attachment 549443 [details] [diff] [review]
remove the --strip-xpi option

Once Flightdeck deploys a version that stops using --strip-xpi (instead just relying upon the fact that it's now the default, via bug 658592), we should remove the --strip-xpi option altogether. I'm guessing this will be in the SDK-1.2 timeframe.
Priority: -- → P3
Target Milestone: --- → 1.2
(Assignee)

Updated

6 years ago
Depends on: 679863
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.2 → ---
(Assignee)

Comment 2

6 years ago
Created attachment 562539 [details] [diff] [review]
remove the --strip-xpi option

updated patch, now ready for review
Attachment #549443 - Attachment is obsolete: true
Attachment #562539 - Flags: review?(myk)
Comment on attachment 562539 [details] [diff] [review]
remove the --strip-xpi option

Is FlightDeck ready for us to land this patch?
Attachment #562539 - Flags: review?(myk) → review+
(Assignee)

Comment 4

6 years ago
I think so.. I think dbuc or piotr told me on IRC that the new version (in which bug 679863 is fixed) should have been pushed to production last wednesday, and in any case the lead time before our release should be plenty to make sure that fix makes it to production first.

I'm going to land it now, but if you hear differently, give a shout and I'll back it out.
(Assignee)

Comment 5

6 years ago
Landed in https://github.com/mozilla/addon-sdk/commit/cded337d4ba463e07b237dd3a0420148d6ed86d2

Setting Target-Milestone to 1.3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in before you can comment on or make changes to this bug.