Closed
Bug 675294
Opened 13 years ago
Closed 13 years ago
remove --strip-xpi option
Categories
(Add-on SDK Graveyard :: General, defect, P3)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.3
People
(Reporter: warner, Assigned: warner)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.06 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
Once Flightdeck deploys a version that stops using --strip-xpi (instead just relying upon the fact that it's now the default, via bug 658592), we should remove the --strip-xpi option altogether. I'm guessing this will be in the SDK-1.2 timeframe.
|
||
Updated•13 years ago
|
Priority: -- → P3
Target Milestone: --- → 1.2
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.2 → ---
|
Assignee | |
Comment 2•13 years ago
|
||
updated patch, now ready for review
Attachment #549443 -
Attachment is obsolete: true
Attachment #562539 -
Flags: review?(myk)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 562539 [details] [diff] [review] remove the --strip-xpi option Is FlightDeck ready for us to land this patch?
Attachment #562539 -
Flags: review?(myk) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
I think so.. I think dbuc or piotr told me on IRC that the new version (in which bug 679863 is fixed) should have been pushed to production last wednesday, and in any case the lead time before our release should be plenty to make sure that fix makes it to production first. I'm going to land it now, but if you hear differently, give a shout and I'll back it out.
|
|
Assignee | |
Comment 5•13 years ago
|
||
Landed in https://github.com/mozilla/addon-sdk/commit/cded337d4ba463e07b237dd3a0420148d6ed86d2 Setting Target-Milestone to 1.3
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3
You need to log in
before you can comment on or make changes to this bug.
Description
•