The default bug view has changed. See this FAQ.

sLastModifierState should be a NSUInteger, not PRBool

RESOLVED FIXED in mozilla8

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

(Depends on: 1 bug)

Trunk
mozilla8
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 549628 [details] [diff] [review]
Fix

This was the only problem found while running boolcheck on OSX.
Attachment #549628 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #549628 - Flags: review? → review?(joshmoz)

Updated

6 years ago
Attachment #549628 - Flags: review?(joshmoz) → review?(smichaud)
Comment on attachment 549628 [details] [diff] [review]
Fix

You need to initialize sLastModifierState to '0'.  Otherwise your patch is fine.

Thanks for catching this.
Attachment #549628 - Flags: review?(smichaud) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/e72269b36c6f
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/e72269b36c6f
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.