Closed
Bug 675483
Opened 14 years ago
Closed 14 years ago
sLastModifierState should be a NSUInteger, not PRBool
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: mwu, Assigned: mwu)
References
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
909 bytes,
patch
|
smichaud
:
review+
|
Details | Diff | Splinter Review |
This was the only problem found while running boolcheck on OSX.
Attachment #549628 -
Flags: review?
|
Assignee | |
Updated•14 years ago
|
Attachment #549628 -
Flags: review? → review?(joshmoz)
Attachment #549628 -
Flags: review?(joshmoz) → review?(smichaud)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 549628 [details] [diff] [review]
Fix
You need to initialize sLastModifierState to '0'. Otherwise your patch is fine.
Thanks for catching this.
Attachment #549628 -
Flags: review?(smichaud) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 3•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in
before you can comment on or make changes to this bug.
Description
•