Closed Bug 675483 Opened 10 years ago Closed 10 years ago

sLastModifierState should be a NSUInteger, not PRBool

Categories

(Core :: Widget: Cocoa, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: mwu, Assigned: mwu)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

Attached patch FixSplinter Review
This was the only problem found while running boolcheck on OSX.
Attachment #549628 - Flags: review?
Attachment #549628 - Flags: review? → review?(joshmoz)
Attachment #549628 - Flags: review?(joshmoz) → review?(smichaud)
Comment on attachment 549628 [details] [diff] [review]
Fix

You need to initialize sLastModifierState to '0'.  Otherwise your patch is fine.

Thanks for catching this.
Attachment #549628 - Flags: review?(smichaud) → review+
http://hg.mozilla.org/mozilla-central/rev/e72269b36c6f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.