Last Comment Bug 675483 - sLastModifierState should be a NSUInteger, not PRBool
: sLastModifierState should be a NSUInteger, not PRBool
Product: Core
Classification: Components
Component: Widget: Cocoa (show other bugs)
: Trunk
: x86 Mac OS X
-- normal (vote)
: mozilla8
Assigned To: Michael Wu [:mwu]
: Markus Stange [:mstange] (away until Feb 22)
Depends on: 669808
  Show dependency treegraph
Reported: 2011-07-30 23:30 PDT by Michael Wu [:mwu]
Modified: 2011-08-02 03:43 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix (909 bytes, patch)
2011-07-30 23:30 PDT, Michael Wu [:mwu]
smichaud: review+
Details | Diff | Splinter Review

Description User image Michael Wu [:mwu] 2011-07-30 23:30:22 PDT
Created attachment 549628 [details] [diff] [review]

This was the only problem found while running boolcheck on OSX.
Comment 1 User image Steven Michaud [:smichaud] (Retired) 2011-08-01 15:56:24 PDT
Comment on attachment 549628 [details] [diff] [review]

You need to initialize sLastModifierState to '0'.  Otherwise your patch is fine.

Thanks for catching this.
Comment 3 User image Marco Bonardo [::mak] 2011-08-02 03:43:57 PDT

Note You need to log in before you can comment on or make changes to this bug.