Closed Bug 675517 Opened 12 years ago Closed 12 years ago

Webservice Bug.comments should include count in result

Categories

(Bugzilla :: WebService, enhancement)

Product:
Bugzilla
Component:
WebService
Version:
4.1.2
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 4.4

People

(Reporter: Frank, Assigned: Frank)

Details

Attachments

(1 file, 1 obsolete file)

patch V2
1.33 KB, patch
mkanat
: review+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7) AppleWebKit/534.48.3 (KHTML, like Gecko) Version/5.1 Safari/534.48.3

Steps to reproduce:

run bug.comment


Actual results:

the count number within the current task is not included in the result map


Expected results:

the count number within the current task should be included in the result map

https://bugzilla.mozilla.org/show_bug.cgi?id=675502 is for the same in show_bug.cgi
Severity: normal → enhancement
Attached patch patch V1 (obsolete) — — Splinter Review 

        Attachment #549684 -
        Flags: review?(mkanat)

    
    

    
  
Comment on attachment 549684 [details] [diff] [review]
patch V1

Okay! Looks fine, but this also needs updates for the docs.

        Attachment #549684 -
        Flags: review?(mkanat) → review-

    
  
Assignee: webservice → Frank
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 5.0

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch V2
        — 
          — Splinter Review
      

    


  
count is now in pod!

        Attachment #550715 -
        Flags: review?(mkanat)

    
    

    
  
Comment on attachment 550715 [details] [diff] [review]
patch V2

Okay. I'm slightly concerned about performance with comments grabbed by comment_id, but I think performance there is already bad and we won't be significantly worsening it this way.

        Attachment #550715 -
        Flags: review?(mkanat) → review+

    
  
Flags: approval?

    
  

        Attachment #549684 -
        Attachment is obsolete: true

    
    

    
  
Great work on this patch, Frank, thanks! :-)

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/WebService/Bug.pm
Committed revision 7912.
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: approval? → approval+
Resolution: --- → FIXED

    
  
Keywords: relnote

    
  
Flags: testcase?

    
    

    
  
Added to the relnotes for 4.4.
Keywords: relnote
Summary: Webservice bug.comment should include count in result → Webservice Bug.comments should include count in result

          You need to log in
          before you can comment on or make changes to this bug.