675558 - HgPoller isn't reconfig safe

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

2011-07-31 12:59:41-0700 [HTTPPageGetter,client] Unhandled error in Deferred:
2011-07-31 12:59:41-0700 [HTTPPageGetter,client] Unhandled Error
        Traceback (most recent call last):
          File "/builds/buildbot/build_scheduler/lib/python2.6/site-packages/twisted/internet/defer.py", line 441, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/builds/buildbot/build_scheduler/lib/python2.6/site-packages/buildbotcustom/changes/hgpoller.py", line 145, in failed
            self.d.errback(fail)
          File "/builds/buildbot/build_scheduler/lib/python2.6/site-packages/twisted/internet/defer.py", line 345, in errback
            self._startRunCallbacks(fail)
          File "/builds/buildbot/build_scheduler/lib/python2.6/site-packages/twisted/internet/defer.py", line 424, in _startRunCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/builds/buildbot/build_scheduler/lib/python2.6/site-packages/twisted/internet/defer.py", line 441, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/builds/buildbot/build_scheduler/lib/python2.6/site-packages/buildbotcustom/changes/hgpoller.py", line 261, in dataFailed
            return BasePoller.dataFailed(self, res)
        exceptions.TypeError: unbound method dataFailed() must be called with BasePoller instance as first argument (got HgPoller instance instead)

2011-07-31 12:59:41-0700 [HTTPPageGetter,client] Stopping factory <HTTPClientFactory: http://hg.mozilla.org/try/json-pushes?full=1&fromchange=fd3cbce2349c9608b17287ca9dc2c2e0bf31c0cc&tipsonly=1>

this ended up breaking the try poller for several hours

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: set self.super_class to BasePoller in BaseHgPoller

Comment 2

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 549714 [details] [diff] [review]
set self.super_class to BasePoller in BaseHgPoller

http://hg.mozilla.org/build/buildbotcustom/rev/e71de976e842

on default.

Comment 3

[Aki Sasaki (not active)]

This is now in production.